diff options
| author | Matt Arsenault <Matthew.Arsenault@amd.com> | 2013-07-20 17:46:05 +0000 |
|---|---|---|
| committer | Matt Arsenault <Matthew.Arsenault@amd.com> | 2013-07-20 17:46:05 +0000 |
| commit | 5f53c3be6fce77d494e82f23d5ea0b6a0144eb5d (patch) | |
| tree | 407d27620b9b6fc54072170b73cabf2b2f8883e5 | |
| parent | 3f49322818a3f2b9ca6fe75f49c7541c8dfb538d (diff) | |
| download | external_llvm-5f53c3be6fce77d494e82f23d5ea0b6a0144eb5d.zip external_llvm-5f53c3be6fce77d494e82f23d5ea0b6a0144eb5d.tar.gz external_llvm-5f53c3be6fce77d494e82f23d5ea0b6a0144eb5d.tar.bz2 | |
Disallow global aliases to bitcast between address spaces
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@186767 91177308-0d34-0410-b5e6-96231b3b80d8
| -rw-r--r-- | lib/IR/Verifier.cpp | 19 | ||||
| -rw-r--r-- | test/Verifier/bitcast-alias-address-space.ll | 8 |
2 files changed, 23 insertions, 4 deletions
diff --git a/lib/IR/Verifier.cpp b/lib/IR/Verifier.cpp index 6e04dfe..fa53a4e 100644 --- a/lib/IR/Verifier.cpp +++ b/lib/IR/Verifier.cpp @@ -498,18 +498,29 @@ void Verifier::visitGlobalAlias(GlobalAlias &GA) { "Alias and aliasee types should match!", &GA); Assert1(!GA.hasUnnamedAddr(), "Alias cannot have unnamed_addr!", &GA); - if (!isa<GlobalValue>(GA.getAliasee())) { - const ConstantExpr *CE = dyn_cast<ConstantExpr>(GA.getAliasee()); + Constant *Aliasee = GA.getAliasee(); + + if (!isa<GlobalValue>(Aliasee)) { + ConstantExpr *CE = dyn_cast<ConstantExpr>(Aliasee); Assert1(CE && (CE->getOpcode() == Instruction::BitCast || CE->getOpcode() == Instruction::GetElementPtr) && isa<GlobalValue>(CE->getOperand(0)), "Aliasee should be either GlobalValue or bitcast of GlobalValue", &GA); + + if (CE->getOpcode() == Instruction::BitCast) { + unsigned SrcAS = CE->getOperand(0)->getType()->getPointerAddressSpace(); + unsigned DstAS = CE->getType()->getPointerAddressSpace(); + + Assert1(SrcAS == DstAS, + "Alias bitcasts cannot be between different address spaces", + &GA); + } } - const GlobalValue* Aliasee = GA.resolveAliasedGlobal(/*stopOnWeak*/ false); - Assert1(Aliasee, + const GlobalValue* Resolved = GA.resolveAliasedGlobal(/*stopOnWeak*/ false); + Assert1(Resolved, "Aliasing chain should end with function or global variable", &GA); visitGlobalValue(GA); diff --git a/test/Verifier/bitcast-alias-address-space.ll b/test/Verifier/bitcast-alias-address-space.ll new file mode 100644 index 0000000..9cad8ab --- /dev/null +++ b/test/Verifier/bitcast-alias-address-space.ll @@ -0,0 +1,8 @@ +; RUN: not llvm-as -verify -disable-output %s + +target datalayout = "e-p:32:32:32-p1:16:16:16-p2:32:32:32-i1:8:32-i8:8:32-i16:16:32-i32:32:32-i64:32:64-f32:32:32-f64:32:64-v64:32:64-v128:32:128-a0:0:32-n8:16:32" + + +@data = addrspace(2) global i32 27 + +@illegal_alias_data = alias bitcast (i32 addrspace(2)* @data to i32 addrspace(1)*) |