diff options
author | Evan Cheng <evan.cheng@apple.com> | 2010-02-01 22:40:09 +0000 |
---|---|---|
committer | Evan Cheng <evan.cheng@apple.com> | 2010-02-01 22:40:09 +0000 |
commit | 7276c8c2b5feb321e60fb849a0a109a52ea330b1 (patch) | |
tree | 824fc88b64ba48ca7e64591391ada46ef14fa99b | |
parent | e7ea6fd7cb951da539d1642121b1e32532d7ec14 (diff) | |
download | external_llvm-7276c8c2b5feb321e60fb849a0a109a52ea330b1.zip external_llvm-7276c8c2b5feb321e60fb849a0a109a52ea330b1.tar.gz external_llvm-7276c8c2b5feb321e60fb849a0a109a52ea330b1.tar.bz2 |
Fix PR6196. GV callee may not be a function.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@95017 91177308-0d34-0410-b5e6-96231b3b80d8
-rw-r--r-- | lib/Target/X86/X86ISelLowering.cpp | 8 | ||||
-rw-r--r-- | test/CodeGen/X86/2010-02-01-TaillCallCrash.ll | 12 |
2 files changed, 17 insertions, 3 deletions
diff --git a/lib/Target/X86/X86ISelLowering.cpp b/lib/Target/X86/X86ISelLowering.cpp index 5b76298..a8308b8 100644 --- a/lib/Target/X86/X86ISelLowering.cpp +++ b/lib/Target/X86/X86ISelLowering.cpp @@ -2288,9 +2288,11 @@ X86TargetLowering::IsEligibleForTailCallOptimization(SDValue Callee, // Don't tail call optimize recursive call. GlobalAddressSDNode *G = dyn_cast<GlobalAddressSDNode>(Callee); if (!G) return false; // FIXME: common external symbols? - const Function *CalleeF = cast<Function>(G->getGlobal()); - const Type *CalleeRetTy = CalleeF->getReturnType(); - return CallerRetTy == CalleeRetTy; + if (const Function *CalleeF = dyn_cast<Function>(G->getGlobal())) { + const Type *CalleeRetTy = CalleeF->getReturnType(); + return CallerRetTy == CalleeRetTy; + } + return false; } FastISel * diff --git a/test/CodeGen/X86/2010-02-01-TaillCallCrash.ll b/test/CodeGen/X86/2010-02-01-TaillCallCrash.ll new file mode 100644 index 0000000..2751174 --- /dev/null +++ b/test/CodeGen/X86/2010-02-01-TaillCallCrash.ll @@ -0,0 +1,12 @@ +; RUN: llc < %s -mtriple=x86_64-unknown-linux-gnu +; PR6196 + +%"char[]" = type [1 x i8] + +@.str = external constant %"char[]", align 1 ; <%"char[]"*> [#uses=1] + +define i32 @regex_subst() nounwind { +entry: + %0 = tail call i32 bitcast (%"char[]"* @.str to i32 (i32)*)(i32 0) nounwind ; <i32> [#uses=1] + ret i32 %0 +} |