diff options
author | Chris Lattner <sabre@nondot.org> | 2011-07-15 23:18:40 +0000 |
---|---|---|
committer | Chris Lattner <sabre@nondot.org> | 2011-07-15 23:18:40 +0000 |
commit | 7305c55a806e550020c0fd78239b587da222f600 (patch) | |
tree | e45a060bffca94c884dc6d86a94cf8ba07b836e5 | |
parent | c1d414ad713406c67c19ff2a1db861046a51cea9 (diff) | |
download | external_llvm-7305c55a806e550020c0fd78239b587da222f600.zip external_llvm-7305c55a806e550020c0fd78239b587da222f600.tar.gz external_llvm-7305c55a806e550020c0fd78239b587da222f600.tar.bz2 |
fix rdar://9776316 - type remapping needed for inline asm blobs,
fixing some objc llvm-test crashes with LTO.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@135324 91177308-0d34-0410-b5e6-96231b3b80d8
-rw-r--r-- | lib/Transforms/Utils/ValueMapper.cpp | 18 | ||||
-rw-r--r-- | test/Linker/inlineasm.ll | 17 |
2 files changed, 34 insertions, 1 deletions
diff --git a/lib/Transforms/Utils/ValueMapper.cpp b/lib/Transforms/Utils/ValueMapper.cpp index e728fd1..973b105 100644 --- a/lib/Transforms/Utils/ValueMapper.cpp +++ b/lib/Transforms/Utils/ValueMapper.cpp @@ -15,6 +15,7 @@ #include "llvm/Transforms/Utils/ValueMapper.h" #include "llvm/Constants.h" #include "llvm/Function.h" +#include "llvm/InlineAsm.h" #include "llvm/Instructions.h" #include "llvm/Metadata.h" using namespace llvm; @@ -31,8 +32,23 @@ Value *llvm::MapValue(const Value *V, ValueToValueMapTy &VM, RemapFlags Flags, // Global values do not need to be seeded into the VM if they // are using the identity mapping. - if (isa<GlobalValue>(V) || isa<InlineAsm>(V) || isa<MDString>(V)) + if (isa<GlobalValue>(V) || isa<MDString>(V)) return VM[V] = const_cast<Value*>(V); + + if (const InlineAsm *IA = dyn_cast<InlineAsm>(V)) { + // Inline asm may need *type* remapping. + FunctionType *NewTy = IA->getFunctionType(); + if (TypeMapper) { + NewTy = cast<FunctionType>(TypeMapper->remapType(NewTy)); + + if (NewTy != IA->getFunctionType()) + V = InlineAsm::get(NewTy, IA->getAsmString(), IA->getConstraintString(), + IA->hasSideEffects(), IA->isAlignStack()); + } + + return VM[V] = const_cast<Value*>(V); + } + if (const MDNode *MD = dyn_cast<MDNode>(V)) { // If this is a module-level metadata and we know that nothing at the module diff --git a/test/Linker/inlineasm.ll b/test/Linker/inlineasm.ll new file mode 100644 index 0000000..d77f3a7 --- /dev/null +++ b/test/Linker/inlineasm.ll @@ -0,0 +1,17 @@ +; RUN: echo > %t.ll +; RUN: llvm-link %t.ll %s -S + +; ModuleID = 'bitfield-access-2.o' +target datalayout = "e-p:32:32:32-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:32:64-f32:32:32-f64:32:64-v64:64:64-v128:128:128-a0:0:64-f80:128:128-n8:16:32" +target triple = "i386-apple-macosx10.6.8" + +; rdar://9776316 - type remapping needed for inline asm blobs. + +%T = type { [18 x i32], [4 x i8*] } + +define void @f(%T* %x) nounwind ssp { +entry: +call void asm sideeffect "", "=*m"(%T* %x) nounwind +unreachable +} + |