diff options
| author | Eli Friedman <eli.friedman@gmail.com> | 2011-03-03 07:24:36 +0000 |
|---|---|---|
| committer | Eli Friedman <eli.friedman@gmail.com> | 2011-03-03 07:24:36 +0000 |
| commit | 78c1e1781cf36dd19988047eac8f664873d35237 (patch) | |
| tree | 5fab182797eb7fac0c8b0a21c1d427964eec0ab9 | |
| parent | 1473f35c47658775e3a9ec23da2a47ff0ef79ac4 (diff) | |
| download | external_llvm-78c1e1781cf36dd19988047eac8f664873d35237.zip external_llvm-78c1e1781cf36dd19988047eac8f664873d35237.tar.gz external_llvm-78c1e1781cf36dd19988047eac8f664873d35237.tar.bz2 | |
PR9352: Always emit a relocation for weak symbols. Not emitting relocations
for calls to weak symbols with a definition has the appearance of working
with LLVM-generated code because weak symbol definitions are put in their
own sections.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@126933 91177308-0d34-0410-b5e6-96231b3b80d8
| -rw-r--r-- | lib/MC/ELFObjectWriter.cpp | 19 | ||||
| -rw-r--r-- | test/MC/ELF/weak-relocation.s | 15 |
2 files changed, 34 insertions, 0 deletions
diff --git a/lib/MC/ELFObjectWriter.cpp b/lib/MC/ELFObjectWriter.cpp index 77017fb..7488b1b 100644 --- a/lib/MC/ELFObjectWriter.cpp +++ b/lib/MC/ELFObjectWriter.cpp @@ -317,6 +317,13 @@ namespace { MCDataFragment *F, const MCSectionData *SD); + virtual bool + IsSymbolRefDifferenceFullyResolvedImpl(const MCAssembler &Asm, + const MCSymbolData &DataA, + const MCFragment &FB, + bool InSet, + bool IsPCRel) const; + virtual void WriteObject(MCAssembler &Asm, const MCAsmLayout &Layout); virtual void WriteSection(MCAssembler &Asm, const SectionIndexMapTy &SectionIndexMap, @@ -1438,6 +1445,18 @@ void ELFObjectWriter::WriteObject(MCAssembler &Asm, } } +bool +ELFObjectWriter::IsSymbolRefDifferenceFullyResolvedImpl(const MCAssembler &Asm, + const MCSymbolData &DataA, + const MCFragment &FB, + bool InSet, + bool IsPCRel) const { + if (DataA.getFlags() & ELF_STB_Weak) + return false; + return MCObjectWriter::IsSymbolRefDifferenceFullyResolvedImpl( + Asm, DataA, FB,InSet, IsPCRel); +} + MCObjectWriter *llvm::createELFObjectWriter(MCELFObjectTargetWriter *MOTW, raw_ostream &OS, bool IsLittleEndian) { diff --git a/test/MC/ELF/weak-relocation.s b/test/MC/ELF/weak-relocation.s new file mode 100644 index 0000000..ef331d7 --- /dev/null +++ b/test/MC/ELF/weak-relocation.s @@ -0,0 +1,15 @@ +// RUN: llvm-mc -filetype=obj -triple x86_64-pc-linux-gnu %s -o - | elf-dump | FileCheck %s + +// Test that weak symbols always produce relocations + + .weak foo +foo: +bar: + call foo + +//CHECK: # Relocation 0x00000000 +//CHECK-NEXT: (('r_offset', 0x00000001) +//CHECK-NEXT: ('r_sym', 0x00000005) +//CHECK-NEXT: ('r_type', 0x00000002) +//CHECK-NEXT: ('r_addend', 0xfffffffc) +//CHECK-NEXT: ), |