aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorChris Lattner <sabre@nondot.org>2009-03-07 08:15:47 +0000
committerChris Lattner <sabre@nondot.org>2009-03-07 08:15:47 +0000
commit922a881f32df95170cb2c28e1a5ee0053d6f0f90 (patch)
tree0b4ff524f939de4ed296be1b615a0f85177ec03d
parentb9c6c9bfe410bbea357503872ce662d6838026ce (diff)
downloadexternal_llvm-922a881f32df95170cb2c28e1a5ee0053d6f0f90.zip
external_llvm-922a881f32df95170cb2c28e1a5ee0053d6f0f90.tar.gz
external_llvm-922a881f32df95170cb2c28e1a5ee0053d6f0f90.tar.bz2
When a crash signal is delivered do two things: remove all of our
signal handlers to prevent reentrance on unrelated things (a sigabort where the handle bus errors) also, clear the signal mask so that the signal doesn't infinitely reissue. This fixes rdar://6654827 - Crash causes clang to loop git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@66330 91177308-0d34-0410-b5e6-96231b3b80d8
-rw-r--r--lib/System/Unix/Signals.inc19
1 files changed, 14 insertions, 5 deletions
diff --git a/lib/System/Unix/Signals.inc b/lib/System/Unix/Signals.inc
index f409cef..94f6b6c 100644
--- a/lib/System/Unix/Signals.inc
+++ b/lib/System/Unix/Signals.inc
@@ -55,13 +55,23 @@ static const int KillSigs[] = {
static const int *const KillSigsEnd =
KillSigs + sizeof(KillSigs) / sizeof(KillSigs[0]);
-// SignalHandler - The signal handler that runs...
+static void UnregisterHandler(int Signal) {
+ signal(Signal, SIG_DFL);
+}
+
+
+// SignalHandler - The signal handler that runs.
static RETSIGTYPE SignalHandler(int Sig) {
// Restore the signal behavior to default, so that the program actually
// crashes when we return and the signal reissues. This also ensures that if
// we crash in our signal handler that the program will terminate immediately
// instead of recursing in the signal handler.
- signal(Sig, SIG_DFL);
+ std::for_each(KillSigs, KillSigsEnd, UnregisterHandler);
+
+ // Unmask all potentially blocked kill signals.
+ sigset_t SigMask;
+ sigfillset(&SigMask);
+ sigprocmask(SIG_UNBLOCK, &SigMask, 0);
if (FilesToRemove != 0)
while (!FilesToRemove->empty()) {
@@ -86,12 +96,11 @@ static RETSIGTYPE SignalHandler(int Sig) {
}
// Just call signal
-static void RegisterHandler(int Signal) {
- signal(Signal, SignalHandler);
+static void RegisterHandler(int Signal) {
+ signal(Signal, SignalHandler);
}
-
void sys::SetInterruptFunction(void (*IF)()) {
InterruptFunction = IF;
RegisterHandler(SIGINT);