diff options
| author | Jim Grosbach <grosbach@apple.com> | 2012-01-24 21:45:25 +0000 |
|---|---|---|
| committer | Jim Grosbach <grosbach@apple.com> | 2012-01-24 21:45:25 +0000 |
| commit | c389af94b66d0c5a917f81617bd07ff0864790a0 (patch) | |
| tree | 2c9642811afb8e0cac396d7da1a2188f1cf87f50 | |
| parent | 3b96e1fe3b695e6d845668ea90d75016f0f46a17 (diff) | |
| download | external_llvm-c389af94b66d0c5a917f81617bd07ff0864790a0.zip external_llvm-c389af94b66d0c5a917f81617bd07ff0864790a0.tar.gz external_llvm-c389af94b66d0c5a917f81617bd07ff0864790a0.tar.bz2 | |
ARM Darwin symbol ref differences w/o subsection-via-symbols.
When not using subsections via symbols, the assembler can resolve
symbol differences (including pcrel references) to non-local
labels at assembly time, not just those in the same atom.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@148865 91177308-0d34-0410-b5e6-96231b3b80d8
| -rw-r--r-- | lib/MC/MachObjectWriter.cpp | 3 | ||||
| -rw-r--r-- | test/MC/MachO/ARM/no-subsections-reloc.s | 18 |
2 files changed, 20 insertions, 1 deletions
diff --git a/lib/MC/MachObjectWriter.cpp b/lib/MC/MachObjectWriter.cpp index a344521..57f90d9 100644 --- a/lib/MC/MachObjectWriter.cpp +++ b/lib/MC/MachObjectWriter.cpp @@ -592,7 +592,8 @@ IsSymbolRefDifferenceFullyResolvedImpl(const MCAssembler &Asm, if (!Asm.getBackend().hasReliableSymbolDifference()) { if (!SA.isInSection() || &SecA != &SecB || (!SA.isTemporary() && - FB.getAtom() != Asm.getSymbolData(SA).getFragment()->getAtom())) + FB.getAtom() != Asm.getSymbolData(SA).getFragment()->getAtom() && + Asm.getSubsectionsViaSymbols())) return false; return true; } diff --git a/test/MC/MachO/ARM/no-subsections-reloc.s b/test/MC/MachO/ARM/no-subsections-reloc.s new file mode 100644 index 0000000..7701c59 --- /dev/null +++ b/test/MC/MachO/ARM/no-subsections-reloc.s @@ -0,0 +1,18 @@ +@ RUN: llvm-mc -n -triple thumbv7-apple-darwin10 %s -filetype=obj -o %t.obj +@ RUN: macho-dump --dump-section-data < %t.obj > %t.dump +@ RUN: FileCheck < %t.dump %s + +@ When not using subsections-via-symbols, references to non-local symbols +@ in the same section can be resolved at assembly time w/o relocations. + + .syntax unified + .text + .thumb + .thumb_func _foo +_foo: + ldr r3, bar +bar: + .long 0 + +@ CHECK: 'num_reloc', 0 +@ CHECK: '_section_data', 'dff80030 00000000' |