diff options
| author | Rafael Espindola <rafael.espindola@gmail.com> | 2010-09-24 18:48:08 +0000 |
|---|---|---|
| committer | Rafael Espindola <rafael.espindola@gmail.com> | 2010-09-24 18:48:08 +0000 |
| commit | cd4b20a25b6251fb4a2ca50813c10184accab24b (patch) | |
| tree | 527d931baf2e4814f022e43b9dbc85dbfc4ff0e1 | |
| parent | 946e3c9f9db2d0ab5bd75ad0283c224366807fa6 (diff) | |
| download | external_llvm-cd4b20a25b6251fb4a2ca50813c10184accab24b.zip external_llvm-cd4b20a25b6251fb4a2ca50813c10184accab24b.tar.gz external_llvm-cd4b20a25b6251fb4a2ca50813c10184accab24b.tar.bz2 | |
Revert 114678 and 114667 to see if
http://google1.osuosl.org:8011/builders/llvm-gcc-i386-linux-selfhost
gets happy.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@114742 91177308-0d34-0410-b5e6-96231b3b80d8
| -rw-r--r-- | lib/MC/ELFObjectWriter.cpp | 7 | ||||
| -rw-r--r-- | test/MC/ELF/local-reloc.s | 32 |
2 files changed, 2 insertions, 37 deletions
diff --git a/lib/MC/ELFObjectWriter.cpp b/lib/MC/ELFObjectWriter.cpp index 9eb9bca..1189b73 100644 --- a/lib/MC/ELFObjectWriter.cpp +++ b/lib/MC/ELFObjectWriter.cpp @@ -515,12 +515,9 @@ void ELFObjectWriterImpl::RecordRelocation(const MCAssembler &Asm, } if (Base) { - if (F && !SD.isExternal()) { + if (F && (!Symbol->isInSection() || SD.isCommon()) && !SD.isExternal()) { Index = F->getParent()->getOrdinal() + LocalSymbolData.size() + 1; - - MCSectionData *FSD = F->getParent(); - // Offset of the symbol in the section - Value += Layout.getSymbolAddress(&SD) - Layout.getSectionAddress(FSD); + Value += Layout.getSymbolAddress(&SD); } else Index = getSymbolIndexInSymbolTable(Asm, Symbol); if (Base != &SD) diff --git a/test/MC/ELF/local-reloc.s b/test/MC/ELF/local-reloc.s deleted file mode 100644 index e5a3d4c..0000000 --- a/test/MC/ELF/local-reloc.s +++ /dev/null @@ -1,32 +0,0 @@ -// RUN: llvm-mc -filetype=obj -triple x86_64-pc-linux-gnu %s -o - | elf-dump --dump-section-data | FileCheck %s - -// Test that relocations with local symbols are represented as relocations -// with the section. They should be equivalent, but gas behaves like this. - - movl foo, %r14d -foo: - -// Section number 1 is .text -// CHECK: # Section 1 -// CHECK-next: (('sh_name', 1) # '.text' - - -// Relocation refers to symbol number 2 -// CHECK: ('_relocations', [ -// CHECK-NEXT: # Relocation 0 -// CHECK-NEXT: (('r_offset', -// CHECK-NEXT: ('r_sym', 2) -// CHECK-NEXT: ('r_type', -// CHECK-NEXT: ('r_addend', -// CHECK-NEXT: ), -// CHECK-NEXT: ]) - -// Symbol number 2 is section number 1 -// CHECK: # Symbol 2 -// CHECK-NEXT: (('st_name', 0) # '' -// CHECK-NEXT: ('st_bind', 0) -// CHECK-NEXT: ('st_type', 3) -// CHECK-NEXT: ('st_other', 0) -// CHECK-NEXT: ('st_shndx', 1) -// CHECK-NEXT: ('st_value', 0) -// CHECK-NEXT: ('st_size', 0) |