diff options
| author | Kevin Enderby <enderby@apple.com> | 2013-08-29 00:19:03 +0000 |
|---|---|---|
| committer | Kevin Enderby <enderby@apple.com> | 2013-08-29 00:19:03 +0000 |
| commit | e54726a87a49e3254696b05787f4635dc59fe750 (patch) | |
| tree | 0ea1260c236a33808143f67fd8aa10365ebd1875 | |
| parent | c08bd51181bd9df392065baa40586aabf94fa80f (diff) | |
| download | external_llvm-e54726a87a49e3254696b05787f4635dc59fe750.zip external_llvm-e54726a87a49e3254696b05787f4635dc59fe750.tar.gz external_llvm-e54726a87a49e3254696b05787f4635dc59fe750.tar.bz2 | |
The darwin integrated assembler for X86 in 64-bit mode is not rejecting
32-bit absolute addressing in instructions likei this:
mov $_f, %rsi
which is not supported in 64-bit mode.
rdar://8827134
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@189543 91177308-0d34-0410-b5e6-96231b3b80d8
| -rw-r--r-- | lib/Target/X86/MCTargetDesc/X86MachObjectWriter.cpp | 7 | ||||
| -rw-r--r-- | test/MC/MachO/bad-darwin-x86_64-32-bit-abs-addr.s | 5 |
2 files changed, 11 insertions, 1 deletions
diff --git a/lib/Target/X86/MCTargetDesc/X86MachObjectWriter.cpp b/lib/Target/X86/MCTargetDesc/X86MachObjectWriter.cpp index 6eff224..9db4cab 100644 --- a/lib/Target/X86/MCTargetDesc/X86MachObjectWriter.cpp +++ b/lib/Target/X86/MCTargetDesc/X86MachObjectWriter.cpp @@ -323,8 +323,13 @@ void X86MachObjectWriter::RecordX86_64Relocation(MachObjectWriter *Writer, report_fatal_error("TLVP symbol modifier should have been rip-rel"); } else if (Modifier != MCSymbolRefExpr::VK_None) report_fatal_error("unsupported symbol modifier in relocation"); - else + else { Type = macho::RIT_X86_64_Unsigned; + unsigned Kind = Fixup.getKind(); + if (Kind == X86::reloc_signed_4byte) + report_fatal_error("32-bit absolute addressing is not supported in " + "64-bit mode"); + } } } diff --git a/test/MC/MachO/bad-darwin-x86_64-32-bit-abs-addr.s b/test/MC/MachO/bad-darwin-x86_64-32-bit-abs-addr.s new file mode 100644 index 0000000..5fcd316 --- /dev/null +++ b/test/MC/MachO/bad-darwin-x86_64-32-bit-abs-addr.s @@ -0,0 +1,5 @@ +// RUN: not llvm-mc -triple x86_64-apple-darwin10 %s -filetype=obj -o - 2> %t.err > %t +// RUN: FileCheck --check-prefix=CHECK-ERROR < %t.err %s + +mov $_f, %rsi +// CHECK-ERROR: 32-bit absolute addressing is not supported in 64-bit mode |