aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDan Gohman <gohman@apple.com>2012-02-17 18:33:38 +0000
committerDan Gohman <gohman@apple.com>2012-02-17 18:33:38 +0000
commitebad58dc58d73097b3546e7fcb6fd7c17336d413 (patch)
tree12db86c66dd0e8ecb96421ef0e92876654748cec
parent7842a741eb0e1baa35af8c3bb5884655c1edaa9e (diff)
downloadexternal_llvm-ebad58dc58d73097b3546e7fcb6fd7c17336d413.zip
external_llvm-ebad58dc58d73097b3546e7fcb6fd7c17336d413.tar.gz
external_llvm-ebad58dc58d73097b3546e7fcb6fd7c17336d413.tar.bz2
Remove a comment about an alternative approach that wouldn't
actually work, at least as described. LLVM Metadata is not intended to suppress LLVM IR rules, as it can be stripped at any time. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@150821 91177308-0d34-0410-b5e6-96231b3b80d8
-rw-r--r--lib/Analysis/BasicAliasAnalysis.cpp5
1 files changed, 1 insertions, 4 deletions
diff --git a/lib/Analysis/BasicAliasAnalysis.cpp b/lib/Analysis/BasicAliasAnalysis.cpp
index 568983a..a831cf2 100644
--- a/lib/Analysis/BasicAliasAnalysis.cpp
+++ b/lib/Analysis/BasicAliasAnalysis.cpp
@@ -977,10 +977,7 @@ BasicAliasAnalysis::aliasGEP(const GEPOperator *GEP1, uint64_t V1Size,
//
// TODO: Returning PartialAlias instead of MayAlias is a mild hack; the
// practical effect of this is protecting TBAA in the case of dynamic
- // indices into arrays of unions. An alternative way to solve this would
- // be to have clang emit extra metadata for unions and/or union accesses.
- // A union-specific solution wouldn't handle the problem for malloc'd
- // memory however.
+ // indices into arrays of unions or malloc'd memory.
return PartialAlias;
}