aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorNick Lewycky <nicholas@mxc.ca>2008-05-17 19:00:05 +0000
committerNick Lewycky <nicholas@mxc.ca>2008-05-17 19:00:05 +0000
commitf35d61af72103b1d0b9a8758fe3ace3cbe2a7488 (patch)
treea50e9bc1928ac0458c71dc95437b6723e67ffebc
parent045fd2257d50995f84241ab00bb26adc0c2a3522 (diff)
downloadexternal_llvm-f35d61af72103b1d0b9a8758fe3ace3cbe2a7488.zip
external_llvm-f35d61af72103b1d0b9a8758fe3ace3cbe2a7488.tar.gz
external_llvm-f35d61af72103b1d0b9a8758fe3ace3cbe2a7488.tar.bz2
Revert constant-folding change that will miscompile in some cases.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51223 91177308-0d34-0410-b5e6-96231b3b80d8
-rw-r--r--lib/VMCore/ConstantFold.cpp23
-rw-r--r--test/Transforms/InstCombine/2008-05-17-FoldIntToPtr.ll8
2 files changed, 0 insertions, 31 deletions
diff --git a/lib/VMCore/ConstantFold.cpp b/lib/VMCore/ConstantFold.cpp
index 07df0bf..0913c48 100644
--- a/lib/VMCore/ConstantFold.cpp
+++ b/lib/VMCore/ConstantFold.cpp
@@ -1029,29 +1029,6 @@ static ICmpInst::Predicate evaluateICmpRelation(const Constant *V1,
}
break;
- case Instruction::PtrToInt:
- case Instruction::IntToPtr:
- // inttoptr(x1) != inttoptr(x2) iff x1 != x2
- if (const ConstantExpr *CE2 = dyn_cast<ConstantExpr>(V2))
- if (CE1->getOpcode() == CE2->getOpcode()) {
- Constant *Op1 = const_cast<Constant*>(CE1Op0);
- Constant *Op2 = CE2->getOperand(0);
- if (Op1->getType() == Op2->getType()) {
- ConstantInt *R = 0;
-
- ICmpInst::Predicate pred = ICmpInst::ICMP_EQ;
- R = dyn_cast<ConstantInt>(ConstantExpr::getICmp(pred, Op1, Op2));
- if (R && !R->isZero())
- return pred;
-
- pred = ICmpInst::ICMP_NE;
- R = dyn_cast<ConstantInt>(ConstantExpr::getICmp(pred, Op1, Op2));
- if (R && !R->isZero())
- return pred;
- }
- }
- break;
-
case Instruction::GetElementPtr:
// Ok, since this is a getelementptr, we know that the constant has a
// pointer type. Check the various cases.
diff --git a/test/Transforms/InstCombine/2008-05-17-FoldIntToPtr.ll b/test/Transforms/InstCombine/2008-05-17-FoldIntToPtr.ll
index 1d93294..e69de29 100644
--- a/test/Transforms/InstCombine/2008-05-17-FoldIntToPtr.ll
+++ b/test/Transforms/InstCombine/2008-05-17-FoldIntToPtr.ll
@@ -1,8 +0,0 @@
-; RUN: llvm-as < %s | opt -instcombine | llvm-dis | grep {ret i1 false}
-; PR2329
-
-define i1 @f() {
- %x = icmp eq i8* inttoptr (i32 1 to i8*), inttoptr (i32 2 to i8*)
- ret i1 %x
-}
-