aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorChad Rosier <mcrosier@apple.com>2013-06-27 20:19:13 +0000
committerChad Rosier <mcrosier@apple.com>2013-06-27 20:19:13 +0000
commitff4196adcf602cbe0581f3240c3fef0847159550 (patch)
tree565b7c99d13d530649289a99ef42b540dd8a5d70
parent4da2ebeefb10390ad16238ae7a1038a987466225 (diff)
downloadexternal_llvm-ff4196adcf602cbe0581f3240c3fef0847159550.zip
external_llvm-ff4196adcf602cbe0581f3240c3fef0847159550.tar.gz
external_llvm-ff4196adcf602cbe0581f3240c3fef0847159550.tar.bz2
Remove unnecessary conditional checks.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@185096 91177308-0d34-0410-b5e6-96231b3b80d8
-rw-r--r--include/llvm/TableGen/Record.h38
1 files changed, 18 insertions, 20 deletions
diff --git a/include/llvm/TableGen/Record.h b/include/llvm/TableGen/Record.h
index 63b72c8..a07898a 100644
--- a/include/llvm/TableGen/Record.h
+++ b/include/llvm/TableGen/Record.h
@@ -1782,30 +1782,28 @@ struct LessRecordRegister {
for (size_t I = 0, E = LHSNumParts; I < E; I+=2) {
std::pair<bool, StringRef> LHSPart = LHSParts.getPart(I);
std::pair<bool, StringRef> RHSPart = RHSParts.getPart(I);
- if ((I & 1) == 0) { // Expect even part to always be alpha.
- assert (LHSPart.first == false && RHSPart.first == false &&
- "Expected both parts to be alpha.");
- if (int Res = LHSPart.second.compare(RHSPart.second))
- return Res < 0;
- }
+ // Expect even part to always be alpha.
+ assert (LHSPart.first == false && RHSPart.first == false &&
+ "Expected both parts to be alpha.");
+ if (int Res = LHSPart.second.compare(RHSPart.second))
+ return Res < 0;
}
for (size_t I = 1, E = LHSNumParts; I < E; I+=2) {
std::pair<bool, StringRef> LHSPart = LHSParts.getPart(I);
std::pair<bool, StringRef> RHSPart = RHSParts.getPart(I);
- if (I & 1) { // Expect odd part to always be numeric.
- assert (LHSPart.first == true && RHSPart.first == true &&
- "Expected both parts to be numeric.");
- if (LHSPart.second.size() != RHSPart.second.size())
- return LHSPart.second.size() < RHSPart.second.size();
-
- unsigned LHSVal, RHSVal;
- if (LHSPart.second.getAsInteger(10, LHSVal))
- assert("Unable to convert LHS to integer.");
- if (RHSPart.second.getAsInteger(10, RHSVal))
- assert("Unable to convert RHS to integer.");
- if (LHSVal != RHSVal)
- return LHSVal < RHSVal;
- }
+ // Expect odd part to always be numeric.
+ assert (LHSPart.first == true && RHSPart.first == true &&
+ "Expected both parts to be numeric.");
+ if (LHSPart.second.size() != RHSPart.second.size())
+ return LHSPart.second.size() < RHSPart.second.size();
+
+ unsigned LHSVal, RHSVal;
+ if (LHSPart.second.getAsInteger(10, LHSVal))
+ assert("Unable to convert LHS to integer.");
+ if (RHSPart.second.getAsInteger(10, RHSVal))
+ assert("Unable to convert RHS to integer.");
+ if (LHSVal != RHSVal)
+ return LHSVal < RHSVal;
}
return LHSNumParts < RHSNumParts;
}