aboutsummaryrefslogtreecommitdiffstats
path: root/autoconf
diff options
context:
space:
mode:
authorDmitri Gribenko <gribozavr@gmail.com>2013-02-13 21:19:39 +0000
committerDmitri Gribenko <gribozavr@gmail.com>2013-02-13 21:19:39 +0000
commit7c62701c2273839f15a65b4f43ac71b270673221 (patch)
tree8c3d6b07a940356abe6584e2cd7a8636fbbc282a /autoconf
parentccb51f923f30b36c9dc0bd9070a29116250428bf (diff)
downloadexternal_llvm-7c62701c2273839f15a65b4f43ac71b270673221.zip
external_llvm-7c62701c2273839f15a65b4f43ac71b270673221.tar.gz
external_llvm-7c62701c2273839f15a65b4f43ac71b270673221.tar.bz2
configure: remove workaround for gcc's -Wno-maybe-uninitialized
Since r174770 gcc version check is not needed because CXX_FLAG_CHECK implements the workaround itself. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@175080 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'autoconf')
-rw-r--r--autoconf/configure.ac28
1 files changed, 5 insertions, 23 deletions
diff --git a/autoconf/configure.ac b/autoconf/configure.ac
index ae615df..b8f1766 100644
--- a/autoconf/configure.ac
+++ b/autoconf/configure.ac
@@ -1272,39 +1272,21 @@ CXX_FLAG_CHECK(NO_VARIADIC_MACROS, [-Wno-variadic-macros])
CXX_FLAG_CHECK(NO_MISSING_FIELD_INITIALIZERS, [-Wno-missing-field-initializers])
CXX_FLAG_CHECK(NO_NESTED_ANON_TYPES, [-Wno-nested-anon-types])
CXX_FLAG_CHECK(COVERED_SWITCH_DEFAULT, [-Wcovered-switch-default])
+
dnl GCC's potential uninitialized use analysis is weak and presents lots of
dnl false positives, so disable it.
+NO_UNINITIALIZED=
+NO_MAYBE_UNINITIALIZED=
if test "$GXX" = "yes"
then
CXX_FLAG_CHECK(NO_MAYBE_UNINITIALIZED, [-Wno-maybe-uninitialized])
dnl gcc 4.7 introduced -Wmaybe-uninitialized to distinguish cases which are
- dnl known to be uninitialized from cases which might be uninitialized. We
+ dnl known to be uninitialized from cases which might be uninitialized. We
dnl still want to catch the first kind of errors.
- if test "$NO_MAYBE_UNINITIALIZED" != "-Wno-maybe-uninitialized"
+ if test -z "$NO_MAYBE_UNINITIALIZED"
then
CXX_FLAG_CHECK(NO_UNINITIALIZED, [-Wno-uninitialized])
- else
- dnl Some versions of gcc accept unsupported -W flags if there is
- dnl no warning but stop with an error when a warning is
- dnl encountered. If this gcc is earlier than 4.7, just use
- dnl -Wno-uninitialized.
- gxx_version=`$CXX -dumpversion`
- gxx_version_major=`echo $gxx_version | cut -d'.' -f1`
- gxx_version_minor=`echo $gxx_version | cut -d'.' -f2`
- gxx_version_patch=`echo $gxx_version | cut -d'.' -f3`
-
- if test "$gxx_version_major" -ge "4" \
- && test "$gxx_version_minor" -ge "7"; then
- dnl AC_SUBST doesn't work with empty strings.
- NO_UNINITIALIZED=
- else
- NO_MAYBE_UNINITIALIZED=
- CXX_FLAG_CHECK(NO_UNINITIALIZED, [-Wno-uninitialized])
- fi
fi
-else
- NO_UNINITIALIZED=
- NO_MAYBE_UNINITIALIZED=
fi
AC_MSG_RESULT([$NO_VARIADIC_MACROS $NO_MISSING_FIELD_INITIALIZERS $NO_NESTED_ANON_TYPES $COVERED_SWITCH_DEFAULT $NO_UNINITIALIZED $NO_MAYBE_UNINITIALIZED])