aboutsummaryrefslogtreecommitdiffstats
path: root/include/llvm/Support/COFF.h
diff options
context:
space:
mode:
authorReid Kleckner <reid@kleckner.net>2013-09-23 23:26:57 +0000
committerReid Kleckner <reid@kleckner.net>2013-09-23 23:26:57 +0000
commit118a0659ab8a4d0e0af343b88e5fa71a5c1eb6a6 (patch)
tree0ccf13d04a66fc600e3ecc221f91bc4ced150676 /include/llvm/Support/COFF.h
parent5a63474e2d4c797ca8245edae4064f17b47df3ee (diff)
downloadexternal_llvm-118a0659ab8a4d0e0af343b88e5fa71a5c1eb6a6.zip
external_llvm-118a0659ab8a4d0e0af343b88e5fa71a5c1eb6a6.tar.gz
external_llvm-118a0659ab8a4d0e0af343b88e5fa71a5c1eb6a6.tar.bz2
Explicitly request unsigned enum types when desired
The underlying type of all plain enums in MSVC is 'int', even if the enumerator contains large 32-bit unsigned values or values greater than UINT_MAX. The only way to get a large or unsigned enum type is to request it explicitly with the C++11 strong enum types feature. However, since LLVM isn't C++11 yet, I had to add a conditional LLVM_ENUM_INT_TYPE to Compiler.h to control its usage. The motivating true positive for this change is compiling PointerIntPair with MSVC for win64. The PointerIntMask value is supposed to be pointer sized value of all ones with some low zeros. Instead, it's truncated to 32-bits! We are only saved later because it is sign extended back in the AND with int64_t, and we happen to want all ones. This silences lots of -Wmicrosoft warnings during a clang self-host targeting Windows. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@191241 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'include/llvm/Support/COFF.h')
-rw-r--r--include/llvm/Support/COFF.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/include/llvm/Support/COFF.h b/include/llvm/Support/COFF.h
index 541d563c..9cc3989 100644
--- a/include/llvm/Support/COFF.h
+++ b/include/llvm/Support/COFF.h
@@ -222,7 +222,7 @@ namespace COFF {
uint32_t Characteristics;
};
- enum SectionCharacteristics {
+ enum SectionCharacteristics LLVM_ENUM_INT_TYPE(uint32_t) {
SC_Invalid = 0xffffffff,
IMAGE_SCN_TYPE_NO_PAD = 0x00000008,