diff options
author | Jeff Cohen <jeffc@jolt-lang.org> | 2005-10-23 04:37:20 +0000 |
---|---|---|
committer | Jeff Cohen <jeffc@jolt-lang.org> | 2005-10-23 04:37:20 +0000 |
commit | 66c5fd6c537269eaef0f630fa14360dcaff6a295 (patch) | |
tree | 90ec39b9c89faa77f29186419eb3f67def5383b1 /include/llvm/Support | |
parent | 8b7f14e970d87eb52ac34e443bb508a403a2ac0d (diff) | |
download | external_llvm-66c5fd6c537269eaef0f630fa14360dcaff6a295.zip external_llvm-66c5fd6c537269eaef0f630fa14360dcaff6a295.tar.gz external_llvm-66c5fd6c537269eaef0f630fa14360dcaff6a295.tar.bz2 |
When a function takes a variable number of pointer arguments, with a zero
pointer marking the end of the list, the zero *must* be cast to the pointer
type. An un-cast zero is a 32-bit int, and at least on x86_64, gcc will
not extend the zero to 64 bits, thus allowing the upper 32 bits to be
random junk.
The new END_WITH_NULL macro may be used to annotate a such a function
so that GCC (version 4 or newer) will detect the use of un-casted zero
at compile time.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@23888 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'include/llvm/Support')
-rw-r--r-- | include/llvm/Support/CommandLine.h | 3 | ||||
-rw-r--r-- | include/llvm/Support/DataTypes.h.in | 6 |
2 files changed, 8 insertions, 1 deletions
diff --git a/include/llvm/Support/CommandLine.h b/include/llvm/Support/CommandLine.h index 10a2f6c..1d499de 100644 --- a/include/llvm/Support/CommandLine.h +++ b/include/llvm/Support/CommandLine.h @@ -21,6 +21,7 @@ #define LLVM_SUPPORT_COMMANDLINE_H #include "llvm/Support/type_traits.h" +#include "llvm/Support/DataTypes.h" #include <string> #include <vector> #include <utility> @@ -335,7 +336,7 @@ public: template<class DataType> ValuesClass<DataType> values(const char *Arg, DataType Val, const char *Desc, - ...) { + ...) END_WITH_NULL { va_list ValueArgs; va_start(ValueArgs, Desc); ValuesClass<DataType> Vals(Arg, Val, Desc, ValueArgs); diff --git a/include/llvm/Support/DataTypes.h.in b/include/llvm/Support/DataTypes.h.in index b99739dc..cfec5f3 100644 --- a/include/llvm/Support/DataTypes.h.in +++ b/include/llvm/Support/DataTypes.h.in @@ -98,4 +98,10 @@ typedef signed int ssize_t; # define UINT64_MAX 0xffffffffffffffffULL #endif +#if __GNUC__ > 3 +#define END_WITH_NULL __attribute__((sentinel)) +#else +#define END_WITH_NULL +#endif + #endif /* SUPPORT_DATATYPES_H */ |