diff options
| author | Jakob Stoklund Olesen <stoklund@2pi.dk> | 2012-08-20 21:05:58 +0000 |
|---|---|---|
| committer | Jakob Stoklund Olesen <stoklund@2pi.dk> | 2012-08-20 21:05:58 +0000 |
| commit | 2c5a960b0eae0634da6e1854111b35f475e65335 (patch) | |
| tree | 3f63ab69e2f23e58a787a3d1dcfb42e15dc396d4 /include | |
| parent | 228e3f5fac0ceef9f6fe22d1621ac32bae5d3177 (diff) | |
| download | external_llvm-2c5a960b0eae0634da6e1854111b35f475e65335.zip external_llvm-2c5a960b0eae0634da6e1854111b35f475e65335.tar.gz external_llvm-2c5a960b0eae0634da6e1854111b35f475e65335.tar.bz2 | |
Clarify that duplicate edges are not allowed in the Machine CFG.
LLVM IR has labeled duplicate CFG edges, but since Machine CFG edges
don't have labels, it doesn't make sense to allow duplicates. There is
no way of telling what the edges mean.
Duplicate CFG edges cause confusion when dealing with edge weights. It
seems that code producing duplicate CFG edges usually does the wrong
thing with edge weights.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@162227 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'include')
| -rw-r--r-- | include/llvm/CodeGen/MachineBasicBlock.h | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/include/llvm/CodeGen/MachineBasicBlock.h b/include/llvm/CodeGen/MachineBasicBlock.h index c917bd8..92d25cc 100644 --- a/include/llvm/CodeGen/MachineBasicBlock.h +++ b/include/llvm/CodeGen/MachineBasicBlock.h @@ -351,6 +351,8 @@ public: /// parameter is stored in Weights list and it may be used by /// MachineBranchProbabilityInfo analysis to calculate branch probability. /// + /// Note that duplicate Machine CFG edges are not allowed. + /// void addSuccessor(MachineBasicBlock *succ, uint32_t weight = 0); /// removeSuccessor - Remove successor from the successors list of this |