diff options
author | Duncan Sands <baldrick@free.fr> | 2008-09-05 21:43:04 +0000 |
---|---|---|
committer | Duncan Sands <baldrick@free.fr> | 2008-09-05 21:43:04 +0000 |
commit | c94fe21a56f9e4e5ebbe99252a25636c36392509 (patch) | |
tree | 1b51a34152f32ad144178190ba7304ededeaf456 /lib/Analysis/IPA | |
parent | f8e35419908270f71597b7fdeab2ac278733904f (diff) | |
download | external_llvm-c94fe21a56f9e4e5ebbe99252a25636c36392509.zip external_llvm-c94fe21a56f9e4e5ebbe99252a25636c36392509.tar.gz external_llvm-c94fe21a56f9e4e5ebbe99252a25636c36392509.tar.bz2 |
Delete the removeCallEdgeTo callgraph method,
because it does not maintain a correct list
of callsites. I discovered (see following
commit) that the inliner will create a wrong
callgraph if it is fed a callgraph with
correct edges but incorrect callsites. These
were created by Prune-EH, and while it wasn't
done via removeCallEdgeTo, it could have been
done via removeCallEdgeTo, which is an accident
waiting to happen. Use removeCallEdgeFor
instead.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@55859 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/Analysis/IPA')
-rw-r--r-- | lib/Analysis/IPA/CallGraph.cpp | 10 |
1 files changed, 0 insertions, 10 deletions
diff --git a/lib/Analysis/IPA/CallGraph.cpp b/lib/Analysis/IPA/CallGraph.cpp index 5616ee9..4a31295 100644 --- a/lib/Analysis/IPA/CallGraph.cpp +++ b/lib/Analysis/IPA/CallGraph.cpp @@ -282,16 +282,6 @@ void CallGraphNode::print(std::ostream &OS) const { void CallGraphNode::dump() const { print(cerr); } -void CallGraphNode::removeCallEdgeTo(CallGraphNode *Callee) { - for (unsigned i = CalledFunctions.size(); ; --i) { - assert(i && "Cannot find callee to remove!"); - if (CalledFunctions[i-1].second == Callee) { - CalledFunctions.erase(CalledFunctions.begin()+i-1); - return; - } - } -} - /// removeCallEdgeFor - This method removes the edge in the node for the /// specified call site. Note that this method takes linear time, so it /// should be used sparingly. |