diff options
| author | Jakob Stoklund Olesen <stoklund@2pi.dk> | 2010-01-26 21:31:35 +0000 |
|---|---|---|
| committer | Jakob Stoklund Olesen <stoklund@2pi.dk> | 2010-01-26 21:31:35 +0000 |
| commit | 026ac3ada52966dd453d3d5dcf4330ff5430e175 (patch) | |
| tree | 02a29421819c69f52a336c8b414898a2e4e8b3e6 /lib/Analysis/InlineCost.cpp | |
| parent | 2cd455f36385eb6ed5c21ae7c52cb3d371810be3 (diff) | |
| download | external_llvm-026ac3ada52966dd453d3d5dcf4330ff5430e175.zip external_llvm-026ac3ada52966dd453d3d5dcf4330ff5430e175.tar.gz external_llvm-026ac3ada52966dd453d3d5dcf4330ff5430e175.tar.bz2 | |
Revert test polarity to match comment and desired outcome. Remove undeserved bonus.
A GEP with all constant indices is already considered free by
analyzeBasicBlock(), so don't give it an extra bonus in
CountCodeReductionForAlloca().
This patch should remove a small positive bias toward inlining functions with
variable-index GEPs, and remove a smaller negative bias from functions with
all-constant index GEPs.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@94591 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/Analysis/InlineCost.cpp')
| -rw-r--r-- | lib/Analysis/InlineCost.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/lib/Analysis/InlineCost.cpp b/lib/Analysis/InlineCost.cpp index ddf78a2..a5a0a98 100644 --- a/lib/Analysis/InlineCost.cpp +++ b/lib/Analysis/InlineCost.cpp @@ -87,8 +87,8 @@ unsigned InlineCostAnalyzer::FunctionInfo:: Reduction += 10; else if (GetElementPtrInst *GEP = dyn_cast<GetElementPtrInst>(I)) { // If the GEP has variable indices, we won't be able to do much with it. - if (!GEP->hasAllConstantIndices()) - Reduction += CountCodeReductionForAlloca(GEP)+15; + if (GEP->hasAllConstantIndices()) + Reduction += CountCodeReductionForAlloca(GEP); } else { // If there is some other strange instruction, we're not going to be able // to do much if we inline this. |