diff options
author | Dan Gohman <gohman@apple.com> | 2010-07-21 18:54:18 +0000 |
---|---|---|
committer | Dan Gohman <gohman@apple.com> | 2010-07-21 18:54:18 +0000 |
commit | 872814ae048df032bddf9299c850f5bda08299a9 (patch) | |
tree | 8abc3d283bd51ea3430c80b7c69f84b8e6067010 /lib/Bitcode/Writer | |
parent | ec237ffd28f1408f524dc134220d8502e167f4d9 (diff) | |
download | external_llvm-872814ae048df032bddf9299c850f5bda08299a9.zip external_llvm-872814ae048df032bddf9299c850f5bda08299a9.tar.gz external_llvm-872814ae048df032bddf9299c850f5bda08299a9.tar.bz2 |
Disallow null as a named metadata operand.
Make MDNode::destroy private.
Fix the one thing that used MDNode::destroy, outside of MDNode itself.
One should never delete or destroy an MDNode explicitly. MDNodes
implicitly go away when there are no references to them (implementation
details aside).
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@109028 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/Bitcode/Writer')
-rw-r--r-- | lib/Bitcode/Writer/BitcodeWriter.cpp | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/lib/Bitcode/Writer/BitcodeWriter.cpp b/lib/Bitcode/Writer/BitcodeWriter.cpp index 985c16c..64c2dfa 100644 --- a/lib/Bitcode/Writer/BitcodeWriter.cpp +++ b/lib/Bitcode/Writer/BitcodeWriter.cpp @@ -558,12 +558,8 @@ static void WriteModuleMetadata(const ValueEnumerator &VE, Record.clear(); // Write named metadata operands. - for (unsigned i = 0, e = NMD->getNumOperands(); i != e; ++i) { - if (NMD->getOperand(i)) - Record.push_back(VE.getValueID(NMD->getOperand(i))); - else - Record.push_back(~0U); - } + for (unsigned i = 0, e = NMD->getNumOperands(); i != e; ++i) + Record.push_back(VE.getValueID(NMD->getOperand(i))); Stream.EmitRecord(bitc::METADATA_NAMED_NODE, Record, 0); Record.clear(); } |