diff options
| author | Chris Lattner <sabre@nondot.org> | 2011-06-20 04:01:31 +0000 |
|---|---|---|
| committer | Chris Lattner <sabre@nondot.org> | 2011-06-20 04:01:31 +0000 |
| commit | b065b06c12dba6001b8140df2744d0c856ef6ea1 (patch) | |
| tree | f5acc3cd50c70497e3cfd6490de4f33190acd81e /lib/Bitcode | |
| parent | 5d6fa7f2ac10f5494d3645abfc91a9045b70c802 (diff) | |
| download | external_llvm-b065b06c12dba6001b8140df2744d0c856ef6ea1.zip external_llvm-b065b06c12dba6001b8140df2744d0c856ef6ea1.tar.gz external_llvm-b065b06c12dba6001b8140df2744d0c856ef6ea1.tar.bz2 | |
Revamp the "ConstantStruct::get" methods. Previously, these were scattered
all over the place in different styles and variants. Standardize on two
preferred entrypoints: one that takes a StructType and ArrayRef, and one that
takes StructType and varargs.
In cases where there isn't a struct type convenient, we now add a
ConstantStruct::getAnon method (whose name will make more sense after a few
more patches land).
It would be "really really nice" if the ConstantStruct::get and
ConstantVector::get methods didn't make temporary std::vectors.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@133412 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/Bitcode')
| -rw-r--r-- | lib/Bitcode/Reader/BitcodeReader.cpp | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/lib/Bitcode/Reader/BitcodeReader.cpp b/lib/Bitcode/Reader/BitcodeReader.cpp index 88c1575..ff67bc9 100644 --- a/lib/Bitcode/Reader/BitcodeReader.cpp +++ b/lib/Bitcode/Reader/BitcodeReader.cpp @@ -292,11 +292,9 @@ void BitcodeReaderValueList::ResolveConstantForwardRefs() { // Make the new constant. Constant *NewC; if (ConstantArray *UserCA = dyn_cast<ConstantArray>(UserC)) { - NewC = ConstantArray::get(UserCA->getType(), &NewOps[0], - NewOps.size()); + NewC = ConstantArray::get(UserCA->getType(), &NewOps[0], NewOps.size()); } else if (ConstantStruct *UserCS = dyn_cast<ConstantStruct>(UserC)) { - NewC = ConstantStruct::get(Context, &NewOps[0], NewOps.size(), - UserCS->getType()->isPacked()); + NewC = ConstantStruct::get(UserCS->getType(), NewOps); } else if (isa<ConstantVector>(UserC)) { NewC = ConstantVector::get(NewOps); } else { |