diff options
author | Chris Lattner <sabre@nondot.org> | 2009-04-29 03:45:07 +0000 |
---|---|---|
committer | Chris Lattner <sabre@nondot.org> | 2009-04-29 03:45:07 +0000 |
commit | 672452d5a0dace689d7f9df9837c03afe3a74281 (patch) | |
tree | f609a874ab32d01b661ce9e7c0532edf4f4c8462 /lib/CodeGen/SelectionDAG | |
parent | f0aa4850ceb61695500437c26e609c4ec394157a (diff) | |
download | external_llvm-672452d5a0dace689d7f9df9837c03afe3a74281.zip external_llvm-672452d5a0dace689d7f9df9837c03afe3a74281.tar.gz external_llvm-672452d5a0dace689d7f9df9837c03afe3a74281.tar.bz2 |
Disable the load-shrinking optimization from looking at
anything larger than 64-bits, avoiding a crash. This should
really be fixed to use APInts, though type legalization happens
to help us out and we get good code on the attached testcase at
least.
This fixes rdar://6836460
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@70360 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/CodeGen/SelectionDAG')
-rw-r--r-- | lib/CodeGen/SelectionDAG/TargetLowering.cpp | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/lib/CodeGen/SelectionDAG/TargetLowering.cpp b/lib/CodeGen/SelectionDAG/TargetLowering.cpp index 96f815f..4de6e35 100644 --- a/lib/CodeGen/SelectionDAG/TargetLowering.cpp +++ b/lib/CodeGen/SelectionDAG/TargetLowering.cpp @@ -1538,19 +1538,22 @@ TargetLowering::SimplifySetCC(MVT VT, SDValue N0, SDValue N1, N0.getOperand(0).getNode()->hasOneUse() && isa<ConstantSDNode>(N0.getOperand(1))) { LoadSDNode *Lod = cast<LoadSDNode>(N0.getOperand(0)); - uint64_t Mask = cast<ConstantSDNode>(N0.getOperand(1))->getZExtValue(); uint64_t bestMask = 0; unsigned bestWidth = 0, bestOffset = 0; - if (!Lod->isVolatile() && Lod->isUnindexed()) { + if (!Lod->isVolatile() && Lod->isUnindexed() && + // FIXME: This uses getZExtValue() below so it only works on i64 and + // below. + N0.getValueType().getSizeInBits() <= 64) { unsigned origWidth = N0.getValueType().getSizeInBits(); // We can narrow (e.g.) 16-bit extending loads on 32-bit target to // 8 bits, but have to be careful... if (Lod->getExtensionType() != ISD::NON_EXTLOAD) origWidth = Lod->getMemoryVT().getSizeInBits(); + uint64_t Mask =cast<ConstantSDNode>(N0.getOperand(1))->getZExtValue(); for (unsigned width = origWidth / 2; width>=8; width /= 2) { uint64_t newMask = (1ULL << width) - 1; for (unsigned offset=0; offset<origWidth/width; offset++) { - if ((newMask & Mask)==Mask) { + if ((newMask & Mask) == Mask) { if (!TD->isLittleEndian()) bestOffset = (origWidth/width - offset - 1) * (width/8); else |