diff options
| author | Jakob Stoklund Olesen <stoklund@2pi.dk> | 2010-08-18 20:06:05 +0000 |
|---|---|---|
| committer | Jakob Stoklund Olesen <stoklund@2pi.dk> | 2010-08-18 20:06:05 +0000 |
| commit | 20270bb45782427d5efd5e2922c5d2ac453038ca (patch) | |
| tree | 18e7a350b178e674b9823e8771b448b2a51dc4ba /lib/CodeGen/SplitKit.cpp | |
| parent | a9a3192baef28d49cc2cb1805048c11626ab3f21 (diff) | |
| download | external_llvm-20270bb45782427d5efd5e2922c5d2ac453038ca.zip external_llvm-20270bb45782427d5efd5e2922c5d2ac453038ca.tar.gz external_llvm-20270bb45782427d5efd5e2922c5d2ac453038ca.tar.bz2 | |
Revert r111394. It was too aggressive.
We must complete the DFS, otherwise we might miss needed phi-defs, and
prematurely color live ranges with a non-dominating value.
This is not a big deal since we get to color more of the CFG and the next
mapValue call will be faster.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@111397 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/CodeGen/SplitKit.cpp')
| -rw-r--r-- | lib/CodeGen/SplitKit.cpp | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/lib/CodeGen/SplitKit.cpp b/lib/CodeGen/SplitKit.cpp index dae282d..b081bf3 100644 --- a/lib/CodeGen/SplitKit.cpp +++ b/lib/CodeGen/SplitKit.cpp @@ -446,9 +446,9 @@ VNInfo *LiveIntervalMap::mapValue(const VNInfo *ParentVNI, SlotIndex Idx) { } // No need to search the children, we found a dominating value. - // MBB is either the found dominating value, or the last phi-def we created. - // Either way, the children of MBB would be shadowed, so don't search them. - IDFI.skipChildren(MBB); + // FIXME: We could prune up to the last phi-def we inserted, need df_iterator + // for that. + IDFI.skipChildren(); } // The search should at least find a dominating value for IdxMBB. |