diff options
| author | David Tweed <david.tweed@arm.com> | 2013-03-19 10:16:40 +0000 |
|---|---|---|
| committer | David Tweed <david.tweed@arm.com> | 2013-03-19 10:16:40 +0000 |
| commit | 974cdfb17a08abae3ba5850bc1a1c801f41319c1 (patch) | |
| tree | 63f7b30c555307e4c518f78749b8bac9e5439e68 /lib/IR/Constants.cpp | |
| parent | 8483b4792621d7d0951d1bdddcb95713ffa2f5d5 (diff) | |
| download | external_llvm-974cdfb17a08abae3ba5850bc1a1c801f41319c1.zip external_llvm-974cdfb17a08abae3ba5850bc1a1c801f41319c1.tar.gz external_llvm-974cdfb17a08abae3ba5850bc1a1c801f41319c1.tar.bz2 | |
The testing to ensure a vector of zeros of type floating point isn't misclassified as negative zero can be simplified, as pointed out by Duncan Sands.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@177386 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/IR/Constants.cpp')
| -rw-r--r-- | lib/IR/Constants.cpp | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/lib/IR/Constants.cpp b/lib/IR/Constants.cpp index 70f7e01..1abb656 100644 --- a/lib/IR/Constants.cpp +++ b/lib/IR/Constants.cpp @@ -53,12 +53,9 @@ bool Constant::isNegativeZeroValue() const { if (SplatCFP && SplatCFP->isZero() && SplatCFP->isNegative()) return true; - // However, vectors of zeroes which are floating point represent +0.0's. - if (const ConstantAggregateZero *CAZ = dyn_cast<ConstantAggregateZero>(this)) - if (const VectorType *VT = dyn_cast<VectorType>(CAZ->getType())) - if (VT->getElementType()->isFloatingPointTy()) - // As it's a CAZ, we know it's the zero bit-pattern (ie, +0.0) in each element. - return false; + // We've already handled true FP case; any other FP vectors can't represent -0.0. + if (getType()->isFPOrFPVectorTy()) + return false; // Otherwise, just use +0.0. return isNullValue(); |