diff options
| author | Hans Wennborg <hans@hanshq.net> | 2013-10-18 02:14:40 +0000 |
|---|---|---|
| committer | Hans Wennborg <hans@hanshq.net> | 2013-10-18 02:14:40 +0000 |
| commit | ab887bf52c99c2c9a4346b6dea2b8118e18a4282 (patch) | |
| tree | 04dbe29e9f0f1ecc3a4626e07cf975b18eff363a /lib/MC/MCSymbol.cpp | |
| parent | 1c165b8ee38c4d960bb4cdd86bc54df144cf5e84 (diff) | |
| download | external_llvm-ab887bf52c99c2c9a4346b6dea2b8118e18a4282.zip external_llvm-ab887bf52c99c2c9a4346b6dea2b8118e18a4282.tar.gz external_llvm-ab887bf52c99c2c9a4346b6dea2b8118e18a4282.tar.bz2 | |
Revert "Re-commit r192758 - MC: quote tricky symbol names in asm output"
This caused the clang-native-mingw32-win7 buildbot to break.
The assembler was complaining about the following lines that were showing up
in the asm for CrashRecoveryContext.cpp:
movl $"__ZL16ExceptionHandlerP19_EXCEPTION_POINTERS@4", 4(%eax)
calll "_AddVectoredExceptionHandler@8"
.def "__ZL16ExceptionHandlerP19_EXCEPTION_POINTERS@4";
"__ZL16ExceptionHandlerP19_EXCEPTION_POINTERS@4":
calll "_RemoveVectoredExceptionHandler@4"
Reverting for now.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@192940 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/MC/MCSymbol.cpp')
| -rw-r--r-- | lib/MC/MCSymbol.cpp | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/lib/MC/MCSymbol.cpp b/lib/MC/MCSymbol.cpp index f386c3b..b973c57 100644 --- a/lib/MC/MCSymbol.cpp +++ b/lib/MC/MCSymbol.cpp @@ -18,10 +18,12 @@ const MCSection *MCSymbol::AbsolutePseudoSection = reinterpret_cast<const MCSection *>(1); static bool isAcceptableChar(char C) { - return (C >= 'a' && C <= 'z') || - (C >= 'A' && C <= 'Z') || - (C >= '0' && C <= '9') || - C == '_' || C == '$' || C == '.'; + if ((C < 'a' || C > 'z') && + (C < 'A' || C > 'Z') && + (C < '0' || C > '9') && + C != '_' && C != '$' && C != '.' && C != '@') + return false; + return true; } /// NameNeedsQuoting - Return true if the identifier \p Str needs quotes to be |