aboutsummaryrefslogtreecommitdiffstats
path: root/lib/MC
diff options
context:
space:
mode:
authorDaniel Dunbar <daniel@zuster.org>2010-03-14 03:10:40 +0000
committerDaniel Dunbar <daniel@zuster.org>2010-03-14 03:10:40 +0000
commitd3da36286f9ffe6951abec67b82837e432c858cf (patch)
treea0fab3b06ff28f2cbc710dd3f5ee7ea492de4af5 /lib/MC
parent7561d480953e0a2faa4af9be0a00b1180097c4bd (diff)
downloadexternal_llvm-d3da36286f9ffe6951abec67b82837e432c858cf.zip
external_llvm-d3da36286f9ffe6951abec67b82837e432c858cf.tar.gz
external_llvm-d3da36286f9ffe6951abec67b82837e432c858cf.tar.bz2
MC: Fix a crash on invalid, attempting to evaluate undefined symbols.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@98464 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/MC')
-rw-r--r--lib/MC/MCExpr.cpp7
-rw-r--r--lib/MC/MCMachOStreamer.cpp2
2 files changed, 5 insertions, 4 deletions
diff --git a/lib/MC/MCExpr.cpp b/lib/MC/MCExpr.cpp
index 8d84f53..3bd6b1b 100644
--- a/lib/MC/MCExpr.cpp
+++ b/lib/MC/MCExpr.cpp
@@ -195,10 +195,11 @@ bool MCExpr::EvaluateAsRelocatable(MCValue &Res,
if (!Sym.getValue()->EvaluateAsRelocatable(Res, Layout))
return false;
- // Absolutize symbol differences when we have a layout object and the
- // target requests it.
+ // Absolutize symbol differences between defined symbols when we have a
+ // layout object and the target requests it.
if (Layout && Res.getSymB() &&
- Layout->getAssembler().getBackend().hasAbsolutizedSet()) {
+ Layout->getAssembler().getBackend().hasAbsolutizedSet() &&
+ Res.getSymA()->isDefined() && Res.getSymB()->isDefined()) {
MCSymbolData &A = Layout->getAssembler().getSymbolData(*Res.getSymA());
MCSymbolData &B = Layout->getAssembler().getSymbolData(*Res.getSymB());
Res = MCValue::get(+ A.getFragment()->getAddress() + A.getOffset()
diff --git a/lib/MC/MCMachOStreamer.cpp b/lib/MC/MCMachOStreamer.cpp
index 2d833ba..73b1074 100644
--- a/lib/MC/MCMachOStreamer.cpp
+++ b/lib/MC/MCMachOStreamer.cpp
@@ -184,7 +184,7 @@ void MCMachOStreamer::EmitAssignment(MCSymbol *Symbol, const MCExpr *Value) {
// FIXME: Lift context changes into super class.
// FIXME: Set associated section.
- Symbol->setValue(Value);
+ Symbol->setValue(AddValueSymbols(Value));
}
void MCMachOStreamer::EmitSymbolAttribute(MCSymbol *Symbol,