aboutsummaryrefslogtreecommitdiffstats
path: root/lib/Target/ARM/MCTargetDesc/ARMUnwindOpAsm.h
diff options
context:
space:
mode:
authorRafael Espindola <rafael.espindola@gmail.com>2013-10-05 16:42:21 +0000
committerRafael Espindola <rafael.espindola@gmail.com>2013-10-05 16:42:21 +0000
commit5e195a4c8d8cd4498ab7e0aa16a3b6f273daf457 (patch)
treef1a16cd335e72328c783313d879489675631f69d /lib/Target/ARM/MCTargetDesc/ARMUnwindOpAsm.h
parent5ccfef6a1d9a5d3fcea56d8900dd35931c793484 (diff)
downloadexternal_llvm-5e195a4c8d8cd4498ab7e0aa16a3b6f273daf457.zip
external_llvm-5e195a4c8d8cd4498ab7e0aa16a3b6f273daf457.tar.gz
external_llvm-5e195a4c8d8cd4498ab7e0aa16a3b6f273daf457.tar.bz2
Remove some really nasty uses of hasRawTextSupport.
When MC was first added, targets could use hasRawTextSupport to keep features working before they were added to the MC interface. The design goal of MC is to provide an uniform api for printing assembly and object files. Short of relaxations and other corner cases, a object file is just another representation of the assembly. It was never the intention that targets would keep doing things like if (hasRawTextSupport()) Set flags in one way. else Set flags in another way. When they do that they create two code paths and the object file is no longer just another representation of the assembly. This also then requires testing with llc -filetype=obj, which is extremelly brittle. This patch removes some of these hacks by replacing them with smaller ones. The ARM flag setting is trivial, so I just moved it to the constructor. For Mips, the patch adds two temporary hack directives that allow the assembly to represent the same things as the object file was already able to. The hope is that the mips developers will replace the hack directives with the same ones that gas uses and drop the -print-hack-directives flag. I will also try to implement a target streamer interface, so that we can move this out of the common code. In summary, for any new work, two rules of the thumb are * Don't use "llc -filetype=obj" in tests. * Don't add calls to hasRawTextSupport. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@192035 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/Target/ARM/MCTargetDesc/ARMUnwindOpAsm.h')
0 files changed, 0 insertions, 0 deletions