diff options
| author | Stuart Hastings <stuart@apple.com> | 2010-06-17 22:43:56 +0000 |
|---|---|---|
| committer | Stuart Hastings <stuart@apple.com> | 2010-06-17 22:43:56 +0000 |
| commit | 9fa5e3347d0fcd2a4626807dc2d8f7ceedf48ffd (patch) | |
| tree | b1fe942e78ac096a427845cd35fc5d69fc5c7492 /lib/Target/MSP430 | |
| parent | d72730e6c8f8ecf016ec482406b2d75ceecacff4 (diff) | |
| download | external_llvm-9fa5e3347d0fcd2a4626807dc2d8f7ceedf48ffd.zip external_llvm-9fa5e3347d0fcd2a4626807dc2d8f7ceedf48ffd.tar.gz external_llvm-9fa5e3347d0fcd2a4626807dc2d8f7ceedf48ffd.tar.bz2 | |
Add a DebugLoc parameter to TargetInstrInfo::InsertBranch(). This
addresses a longstanding deficiency noted in many FIXMEs scattered
across all the targets.
This effectively moves the problem up one level, replacing eleven
FIXMEs in the targets with eight FIXMEs in CodeGen, plus one path
through FastISel where we actually supply a DebugLoc, fixing Radar
7421831.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@106243 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/Target/MSP430')
| -rw-r--r-- | lib/Target/MSP430/MSP430InstrInfo.cpp | 6 | ||||
| -rw-r--r-- | lib/Target/MSP430/MSP430InstrInfo.h | 3 |
2 files changed, 4 insertions, 5 deletions
diff --git a/lib/Target/MSP430/MSP430InstrInfo.cpp b/lib/Target/MSP430/MSP430InstrInfo.cpp index 18226ab..2aa8f69 100644 --- a/lib/Target/MSP430/MSP430InstrInfo.cpp +++ b/lib/Target/MSP430/MSP430InstrInfo.cpp @@ -330,10 +330,8 @@ bool MSP430InstrInfo::AnalyzeBranch(MachineBasicBlock &MBB, unsigned MSP430InstrInfo::InsertBranch(MachineBasicBlock &MBB, MachineBasicBlock *TBB, MachineBasicBlock *FBB, - const SmallVectorImpl<MachineOperand> &Cond) const { - // FIXME this should probably have a DebugLoc operand - DebugLoc DL; - + const SmallVectorImpl<MachineOperand> &Cond, + DebugLoc DL) const { // Shouldn't be a fall through. assert(TBB && "InsertBranch must not be told to insert a fallthrough"); assert((Cond.size() == 1 || Cond.size() == 0) && diff --git a/lib/Target/MSP430/MSP430InstrInfo.h b/lib/Target/MSP430/MSP430InstrInfo.h index 842b4cb..3b012cb 100644 --- a/lib/Target/MSP430/MSP430InstrInfo.h +++ b/lib/Target/MSP430/MSP430InstrInfo.h @@ -93,7 +93,8 @@ public: unsigned RemoveBranch(MachineBasicBlock &MBB) const; unsigned InsertBranch(MachineBasicBlock &MBB, MachineBasicBlock *TBB, MachineBasicBlock *FBB, - const SmallVectorImpl<MachineOperand> &Cond) const; + const SmallVectorImpl<MachineOperand> &Cond, + DebugLoc DL) const; }; |