diff options
| author | Stuart Hastings <stuart@apple.com> | 2010-06-17 22:43:56 +0000 |
|---|---|---|
| committer | Stuart Hastings <stuart@apple.com> | 2010-06-17 22:43:56 +0000 |
| commit | 9fa5e3347d0fcd2a4626807dc2d8f7ceedf48ffd (patch) | |
| tree | b1fe942e78ac096a427845cd35fc5d69fc5c7492 /lib/Target/PIC16 | |
| parent | d72730e6c8f8ecf016ec482406b2d75ceecacff4 (diff) | |
| download | external_llvm-9fa5e3347d0fcd2a4626807dc2d8f7ceedf48ffd.zip external_llvm-9fa5e3347d0fcd2a4626807dc2d8f7ceedf48ffd.tar.gz external_llvm-9fa5e3347d0fcd2a4626807dc2d8f7ceedf48ffd.tar.bz2 | |
Add a DebugLoc parameter to TargetInstrInfo::InsertBranch(). This
addresses a longstanding deficiency noted in many FIXMEs scattered
across all the targets.
This effectively moves the problem up one level, replacing eleven
FIXMEs in the targets with eight FIXMEs in CodeGen, plus one path
through FastISel where we actually supply a DebugLoc, fixing Radar
7421831.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@106243 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/Target/PIC16')
| -rw-r--r-- | lib/Target/PIC16/PIC16InstrInfo.cpp | 6 | ||||
| -rw-r--r-- | lib/Target/PIC16/PIC16InstrInfo.h | 3 |
2 files changed, 5 insertions, 4 deletions
diff --git a/lib/Target/PIC16/PIC16InstrInfo.cpp b/lib/Target/PIC16/PIC16InstrInfo.cpp index 793dd9f..e55cb44 100644 --- a/lib/Target/PIC16/PIC16InstrInfo.cpp +++ b/lib/Target/PIC16/PIC16InstrInfo.cpp @@ -196,15 +196,15 @@ bool PIC16InstrInfo::isMoveInstr(const MachineInstr &MI, unsigned PIC16InstrInfo:: InsertBranch(MachineBasicBlock &MBB, MachineBasicBlock *TBB, MachineBasicBlock *FBB, - const SmallVectorImpl<MachineOperand> &Cond) const { + const SmallVectorImpl<MachineOperand> &Cond, + DebugLoc DL) const { // Shouldn't be a fall through. assert(TBB && "InsertBranch must not be told to insert a fallthrough"); if (FBB == 0) { // One way branch. if (Cond.empty()) { // Unconditional branch? - DebugLoc dl; - BuildMI(&MBB, dl, get(PIC16::br_uncond)).addMBB(TBB); + BuildMI(&MBB, DL, get(PIC16::br_uncond)).addMBB(TBB); } return 1; } diff --git a/lib/Target/PIC16/PIC16InstrInfo.h b/lib/Target/PIC16/PIC16InstrInfo.h index 40a4cb4..eeefa56 100644 --- a/lib/Target/PIC16/PIC16InstrInfo.h +++ b/lib/Target/PIC16/PIC16InstrInfo.h @@ -70,7 +70,8 @@ public: virtual unsigned InsertBranch(MachineBasicBlock &MBB, MachineBasicBlock *TBB, MachineBasicBlock *FBB, - const SmallVectorImpl<MachineOperand> &Cond) const; + const SmallVectorImpl<MachineOperand> &Cond, + DebugLoc DL) const; virtual bool AnalyzeBranch(MachineBasicBlock &MBB, MachineBasicBlock *&TBB, MachineBasicBlock *&FBB, SmallVectorImpl<MachineOperand> &Cond, |