aboutsummaryrefslogtreecommitdiffstats
path: root/lib/Target/X86/X86FastISel.cpp
diff options
context:
space:
mode:
authorDavid Blaikie <dblaikie@gmail.com>2013-06-21 22:56:30 +0000
committerDavid Blaikie <dblaikie@gmail.com>2013-06-21 22:56:30 +0000
commit1948910e3186d31bc0d213ecd0d7e87bb2c2760d (patch)
tree72933564b70b854dfc26c146d92c8743e87da24c /lib/Target/X86/X86FastISel.cpp
parentb37e50b6601c0551b36d59b01fe80b9acd4703e5 (diff)
downloadexternal_llvm-1948910e3186d31bc0d213ecd0d7e87bb2c2760d.zip
external_llvm-1948910e3186d31bc0d213ecd0d7e87bb2c2760d.tar.gz
external_llvm-1948910e3186d31bc0d213ecd0d7e87bb2c2760d.tar.bz2
DebugInfo: Don't lose unreferenced non-trivial by-value parameters
A FastISel optimization was causing us to emit no information for such parameters & when they go missing we end up emitting a different function type. By avoiding that shortcut we not only get types correct (very important) but also location information (handy) - even if it's only live at the start of a function & may be clobbered later. Reviewed/discussion by Evan Cheng & Dan Gohman. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@184604 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/Target/X86/X86FastISel.cpp')
-rw-r--r--lib/Target/X86/X86FastISel.cpp2
1 files changed, 0 insertions, 2 deletions
diff --git a/lib/Target/X86/X86FastISel.cpp b/lib/Target/X86/X86FastISel.cpp
index 295a577..669108f 100644
--- a/lib/Target/X86/X86FastISel.cpp
+++ b/lib/Target/X86/X86FastISel.cpp
@@ -1732,8 +1732,6 @@ bool X86FastISel::FastLowerArguments() {
const TargetRegisterClass *RC64 = TLI.getRegClassFor(MVT::i64);
for (Function::const_arg_iterator I = F->arg_begin(), E = F->arg_end();
I != E; ++I, ++Idx) {
- if (I->use_empty())
- continue;
bool is32Bit = TLI.getValueType(I->getType()) == MVT::i32;
const TargetRegisterClass *RC = is32Bit ? RC32 : RC64;
unsigned SrcReg = is32Bit ? GPR32ArgRegs[Idx] : GPR64ArgRegs[Idx];