diff options
author | Ahmed Charles <ace2001ac@gmail.com> | 2012-02-13 06:30:56 +0000 |
---|---|---|
committer | Ahmed Charles <ace2001ac@gmail.com> | 2012-02-13 06:30:56 +0000 |
commit | b83a67e1e3fe210bd99a82eccd3dc5b1b44f1503 (patch) | |
tree | a8eb88c098f90f4406774107d82dac131287200e /lib/Target/X86 | |
parent | 4eaca023dce4f204f937526c803c3430cf541a1b (diff) | |
download | external_llvm-b83a67e1e3fe210bd99a82eccd3dc5b1b44f1503.zip external_llvm-b83a67e1e3fe210bd99a82eccd3dc5b1b44f1503.tar.gz external_llvm-b83a67e1e3fe210bd99a82eccd3dc5b1b44f1503.tar.bz2 |
Fix various issues (or do cleanups) found by enabling certain MSVC warnings.
- Use unsigned literals when the desired result is unsigned. This mostly allows unsigned/signed mismatch warnings to be less noisy even if they aren't on by default.
- Remove misplaced llvm_unreachable.
- Add static to a declaration of a function on MSVC x86 only.
- Change some instances of calling a static function through a variable to simply calling that function while removing the unused variable.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@150364 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/Target/X86')
-rw-r--r-- | lib/Target/X86/X86JITInfo.cpp | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/lib/Target/X86/X86JITInfo.cpp b/lib/Target/X86/X86JITInfo.cpp index 29b623e..0168d12 100644 --- a/lib/Target/X86/X86JITInfo.cpp +++ b/lib/Target/X86/X86JITInfo.cpp @@ -300,7 +300,10 @@ extern "C" { SIZE(X86CompilationCallback_SSE) ); # else - void X86CompilationCallback2(intptr_t *StackPtr, intptr_t RetAddr); + // the following function is called only from this translation unit, + // unless we are under 64bit Windows with MSC, where there is + // no support for inline assembly + static void X86CompilationCallback2(intptr_t *StackPtr, intptr_t RetAddr); _declspec(naked) void X86CompilationCallback(void) { __asm { |