diff options
author | Owen Anderson <resistor@mac.com> | 2010-09-16 23:32:35 +0000 |
---|---|---|
committer | Owen Anderson <resistor@mac.com> | 2010-09-16 23:32:35 +0000 |
commit | 1e3e6362c8def5abcbc9a89c02619a0912177f7e (patch) | |
tree | fd3675c9cbda3c04c8482036dcfe49cda057ecbb /lib/VMCore | |
parent | fc24c1a7ba4ad1383726079eed6d67097614ee84 (diff) | |
download | external_llvm-1e3e6362c8def5abcbc9a89c02619a0912177f7e.zip external_llvm-1e3e6362c8def5abcbc9a89c02619a0912177f7e.tar.gz external_llvm-1e3e6362c8def5abcbc9a89c02619a0912177f7e.tar.bz2 |
Do not expose the locking for the PassRegistry in the header. Be careful to
synchronize any method that might lazily initialize the pImpl.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@114130 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib/VMCore')
-rw-r--r-- | lib/VMCore/PassRegistry.cpp | 9 |
1 files changed, 8 insertions, 1 deletions
diff --git a/lib/VMCore/PassRegistry.cpp b/lib/VMCore/PassRegistry.cpp index 0b4e59d..6156577 100644 --- a/lib/VMCore/PassRegistry.cpp +++ b/lib/VMCore/PassRegistry.cpp @@ -16,6 +16,7 @@ #include "llvm/PassSupport.h" #include "llvm/Support/Compiler.h" #include "llvm/Support/ManagedStatic.h" +#include "llvm/System/Mutex.h" #include "llvm/ADT/DenseMap.h" #include "llvm/ADT/SmallPtrSet.h" #include "llvm/ADT/StringMap.h" @@ -33,6 +34,8 @@ PassRegistry *PassRegistry::getPassRegistry() { return &*PassRegistryObj; } +sys::SmartMutex<true> Lock; + //===----------------------------------------------------------------------===// // PassRegistryImpl // @@ -65,18 +68,21 @@ void *PassRegistry::getImpl() const { // PassRegistry::~PassRegistry() { + sys::SmartScopedLock<true> Guard(Lock); PassRegistryImpl *Impl = static_cast<PassRegistryImpl*>(pImpl); if (Impl) delete Impl; pImpl = 0; } const PassInfo *PassRegistry::getPassInfo(const void *TI) const { + sys::SmartScopedLock<true> Guard(Lock); PassRegistryImpl *Impl = static_cast<PassRegistryImpl*>(getImpl()); PassRegistryImpl::MapType::const_iterator I = Impl->PassInfoMap.find(TI); return I != Impl->PassInfoMap.end() ? I->second : 0; } const PassInfo *PassRegistry::getPassInfo(StringRef Arg) const { + sys::SmartScopedLock<true> Guard(Lock); PassRegistryImpl *Impl = static_cast<PassRegistryImpl*>(getImpl()); PassRegistryImpl::StringMapType::const_iterator I = Impl->PassInfoStringMap.find(Arg); @@ -127,7 +133,6 @@ void PassRegistry::registerAnalysisGroup(const void *InterfaceID, const void *PassID, PassInfo& Registeree, bool isDefault) { - sys::SmartScopedLock<true> Guard(Lock); PassInfo *InterfaceInfo = const_cast<PassInfo*>(getPassInfo(InterfaceID)); if (InterfaceInfo == 0) { // First reference to Interface, register it now. @@ -142,6 +147,8 @@ void PassRegistry::registerAnalysisGroup(const void *InterfaceID, assert(ImplementationInfo && "Must register pass before adding to AnalysisGroup!"); + sys::SmartScopedLock<true> Guard(Lock); + // Make sure we keep track of the fact that the implementation implements // the interface. ImplementationInfo->addInterfaceImplemented(InterfaceInfo); |