diff options
| author | Chandler Carruth <chandlerc@gmail.com> | 2012-02-21 08:31:18 +0000 |
|---|---|---|
| committer | Chandler Carruth <chandlerc@gmail.com> | 2012-02-21 08:31:18 +0000 |
| commit | 0523f41841d0860b2e175a4b20d1ecefd7295c4a (patch) | |
| tree | 75f51a1badfb7f2e3dd1ecc317f3c45ca7affa24 /lib | |
| parent | 7d9b20792bfc528647f8bd7644934b228cc6c60b (diff) | |
| download | external_llvm-0523f41841d0860b2e175a4b20d1ecefd7295c4a.zip external_llvm-0523f41841d0860b2e175a4b20d1ecefd7295c4a.tar.gz external_llvm-0523f41841d0860b2e175a4b20d1ecefd7295c4a.tar.bz2 | |
Clean up comments that I missed when changing the triple representation.
Somehow, I even missed the ones I wrote just the other day...
Thanks to Matt for the code review.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@151045 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/Support/Triple.cpp | 17 |
1 files changed, 7 insertions, 10 deletions
diff --git a/lib/Support/Triple.cpp b/lib/Support/Triple.cpp index af951fe..b5aa519 100644 --- a/lib/Support/Triple.cpp +++ b/lib/Support/Triple.cpp @@ -292,10 +292,8 @@ Triple::EnvironmentType Triple::ParseEnvironment(StringRef EnvironmentName) { /// \brief Construct a triple from the string representation provided. /// -/// This doesn't actually parse the string representation eagerly. Instead it -/// stores it, and tracks the fact that it hasn't been parsed. The first time -/// any of the structural queries are made, the string is parsed and the -/// results cached in various members. +/// This stores the string representation and parses the various pieces into +/// enum members. Triple::Triple(const Twine &Str) : Data(Str.str()), Arch(ParseArch(getArchName())), @@ -307,9 +305,9 @@ Triple::Triple(const Twine &Str) /// \brief Construct a triple from string representations of the architecture, /// vendor, and OS. /// -/// This doesn't actually use these already distinct strings to setup the -/// triple information. Instead it joins them into a canonical form of a triple -/// string, and lazily parses it on use. +/// This joins each argument into a canonical string representation and parses +/// them into enum members. It leaves the environment unknown and omits it from +/// the string representation. Triple::Triple(const Twine &ArchStr, const Twine &VendorStr, const Twine &OSStr) : Data((ArchStr + Twine('-') + VendorStr + Twine('-') + OSStr).str()), Arch(ParseArch(ArchStr.str())), @@ -321,9 +319,8 @@ Triple::Triple(const Twine &ArchStr, const Twine &VendorStr, const Twine &OSStr) /// \brief Construct a triple from string representations of the architecture, /// vendor, OS, and environment. /// -/// This doesn't actually use these already distinct strings to setup the -/// triple information. Instead it joins them into a canonical form of a triple -/// string, and lazily parses it on use. +/// This joins each argument into a canonical string representation and parses +/// them into enum members. Triple::Triple(const Twine &ArchStr, const Twine &VendorStr, const Twine &OSStr, const Twine &EnvironmentStr) : Data((ArchStr + Twine('-') + VendorStr + Twine('-') + OSStr + Twine('-') + |