diff options
author | Chris Lattner <sabre@nondot.org> | 2010-11-14 20:31:06 +0000 |
---|---|---|
committer | Chris Lattner <sabre@nondot.org> | 2010-11-14 20:31:06 +0000 |
commit | 112f2390e19774a54c2dd50391b99fb617da0973 (patch) | |
tree | e91929ed61252788c361e5e6120e8d5014d37689 /lib | |
parent | fdb2ded765316ee2ee2f796b0e2befa2c23acd1d (diff) | |
download | external_llvm-112f2390e19774a54c2dd50391b99fb617da0973.zip external_llvm-112f2390e19774a54c2dd50391b99fb617da0973.tar.gz external_llvm-112f2390e19774a54c2dd50391b99fb617da0973.tar.bz2 |
simplify and tidy up
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@119066 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'lib')
-rw-r--r-- | lib/Target/ARM/ARMAsmPrinter.cpp | 3 | ||||
-rw-r--r-- | lib/Target/ARM/ARMMCInstLower.cpp | 37 | ||||
-rw-r--r-- | lib/Target/ARM/ARMMCInstLower.h | 17 |
3 files changed, 16 insertions, 41 deletions
diff --git a/lib/Target/ARM/ARMAsmPrinter.cpp b/lib/Target/ARM/ARMAsmPrinter.cpp index 73d3e1c..2d5b4c4 100644 --- a/lib/Target/ARM/ARMAsmPrinter.cpp +++ b/lib/Target/ARM/ARMAsmPrinter.cpp @@ -802,9 +802,8 @@ void ARMAsmPrinter::PrintDebugValueComment(const MachineInstr *MI, void ARMAsmPrinter::EmitInstruction(const MachineInstr *MI) { ARMMCInstLower MCInstLowering(OutContext, *Mang, *this); switch (MI->getOpcode()) { - case ARM::t2MOVi32imm: - assert(0 && "Should be lowered by thumb2it pass"); default: break; + case ARM::t2MOVi32imm: assert(0 && "Should be lowered by thumb2it pass"); case ARM::DBG_VALUE: { if (isVerbose() && OutStreamer.hasRawTextSupport()) { SmallString<128> TmpStr; diff --git a/lib/Target/ARM/ARMMCInstLower.cpp b/lib/Target/ARM/ARMMCInstLower.cpp index e2155f1..12ad3ec 100644 --- a/lib/Target/ARM/ARMMCInstLower.cpp +++ b/lib/Target/ARM/ARMMCInstLower.cpp @@ -12,8 +12,8 @@ // //===----------------------------------------------------------------------===// -#include "ARM.h" #include "ARMMCInstLower.h" +#include "ARM.h" #include "llvm/CodeGen/AsmPrinter.h" #include "llvm/Constants.h" #include "llvm/CodeGen/MachineBasicBlock.h" @@ -82,7 +82,7 @@ GetExternalSymbolSymbol(const MachineOperand &MO) const { -MCSymbol *ARMMCInstLower:: +const MCSymbolRefExpr *ARMMCInstLower:: GetJumpTableSymbol(const MachineOperand &MO) const { SmallString<256> Name; raw_svector_ostream(Name) << Printer.MAI->getPrivateGlobalPrefix() << "JTI" @@ -94,10 +94,10 @@ GetJumpTableSymbol(const MachineOperand &MO) const { } // Create a symbol for the name. - return Ctx.GetOrCreateSymbol(Name.str()); + return MCSymbolRefExpr::Create(Ctx.GetOrCreateSymbol(Name.str()), Ctx); } -MCSymbol *ARMMCInstLower:: +const MCSymbolRefExpr *ARMMCInstLower:: GetConstantPoolIndexSymbol(const MachineOperand &MO) const { SmallString<256> Name; raw_svector_ostream(Name) << Printer.MAI->getPrivateGlobalPrefix() << "CPI" @@ -109,25 +109,7 @@ GetConstantPoolIndexSymbol(const MachineOperand &MO) const { } // Create a symbol for the name. - return Ctx.GetOrCreateSymbol(Name.str()); -} - -MCOperand ARMMCInstLower:: -LowerSymbolOperand(const MachineOperand &MO, MCSymbol *Sym) const { - // FIXME: We would like an efficient form for this, so we don't have to do a - // lot of extra uniquing. - const MCExpr *Expr = MCSymbolRefExpr::Create(Sym, Ctx); - - switch (MO.getTargetFlags()) { - default: assert(0 && "Unknown target flag on Symbol operand"); - case 0: break; - } - - if (!MO.isJTI() && MO.getOffset()) - Expr = MCBinaryExpr::CreateAdd(Expr, - MCConstantExpr::Create(MO.getOffset(), Ctx), - Ctx); - return MCOperand::CreateExpr(Expr); + return MCSymbolRefExpr::Create(Ctx.GetOrCreateSymbol(Name.str()), Ctx); } MCOperand ARMMCInstLower:: @@ -173,14 +155,15 @@ void ARMMCInstLower::Lower(const MachineInstr *MI, MCInst &OutMI) const { MCOp = LowerSymbolRefOperand(MO, GetExternalSymbolSymbol(MO)); break; case MachineOperand::MO_JumpTableIndex: - MCOp = LowerSymbolOperand(MO, GetJumpTableSymbol(MO)); + MCOp = LowerSymbolRefOperand(MO, GetJumpTableSymbol(MO)); break; case MachineOperand::MO_ConstantPoolIndex: - MCOp = LowerSymbolOperand(MO, GetConstantPoolIndexSymbol(MO)); + MCOp = LowerSymbolRefOperand(MO, GetConstantPoolIndexSymbol(MO)); break; case MachineOperand::MO_BlockAddress: - MCOp = LowerSymbolOperand(MO, Printer.GetBlockAddressSymbol( - MO.getBlockAddress())); + MCOp = LowerSymbolRefOperand(MO, + MCSymbolRefExpr::Create(Printer.GetBlockAddressSymbol( + MO.getBlockAddress()), Ctx)); break; case MachineOperand::MO_FPImmediate: APFloat Val = MO.getFPImm()->getValueAPF(); diff --git a/lib/Target/ARM/ARMMCInstLower.h b/lib/Target/ARM/ARMMCInstLower.h index c4d27f8..5645cc5 100644 --- a/lib/Target/ARM/ARMMCInstLower.h +++ b/lib/Target/ARM/ARMMCInstLower.h @@ -32,31 +32,24 @@ class LLVM_LIBRARY_VISIBILITY ARMMCInstLower { MCContext &Ctx; Mangler &Mang; AsmPrinter &Printer; - - //const ARMSubtarget &getSubtarget() const; public: ARMMCInstLower(MCContext &ctx, Mangler &mang, AsmPrinter &printer) : Ctx(ctx), Mang(mang), Printer(printer) {} void Lower(const MachineInstr *MI, MCInst &OutMI) const; - //MCSymbol *GetPICBaseSymbol() const; +private: MCSymbol *GetGlobalAddressSymbol(const GlobalValue *GV) const; const MCSymbolRefExpr *GetSymbolRef(const MachineOperand &MO) const; const MCSymbolRefExpr *GetExternalSymbolSymbol(const MachineOperand &MO) const; - MCSymbol *GetJumpTableSymbol(const MachineOperand &MO) const; - MCSymbol *GetConstantPoolIndexSymbol(const MachineOperand &MO) const; + const MCSymbolRefExpr *GetJumpTableSymbol(const MachineOperand &MO) const; + const MCSymbolRefExpr * + GetConstantPoolIndexSymbol(const MachineOperand &MO) const; MCOperand LowerSymbolRefOperand(const MachineOperand &MO, const MCSymbolRefExpr *Expr) const; - MCOperand LowerSymbolOperand(const MachineOperand &MO, MCSymbol *Sym) const; - -/* -private: - MachineModuleInfoMachO &getMachOMMI() const; - */ }; -} +} // end namespace llvm #endif |