diff options
author | Gordon Henriksen <gordonhenriksen@mac.com> | 2007-09-17 20:30:04 +0000 |
---|---|---|
committer | Gordon Henriksen <gordonhenriksen@mac.com> | 2007-09-17 20:30:04 +0000 |
commit | 8c33da5dc4144d6df474dcea986ca05932e2fe10 (patch) | |
tree | 73654f8d76cfc48a3bf0224fab3aa19c380acfdf /test | |
parent | ca8035e3569afd5a8d0ef406b82dad1b7e673683 (diff) | |
download | external_llvm-8c33da5dc4144d6df474dcea986ca05932e2fe10.zip external_llvm-8c33da5dc4144d6df474dcea986ca05932e2fe10.tar.gz external_llvm-8c33da5dc4144d6df474dcea986ca05932e2fe10.tar.bz2 |
Fix for PR1633: Verifier doesn't fully verify GC intrinsics
LLVM now enforces the following prototypes for the write barriers:
<ty>* @llvm.gcread(<ty2>*, <ty>**)
void @llvm.gcwrite(<ty>*, <ty2>*, <ty>**)
And for @llvm.gcroot, the first stack slot is verified to be an alloca or a
bitcast of an alloca.
Fixes test/CodeGen/Generic/GC/lower_gcroot.ll, which violated these.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@42051 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'test')
-rw-r--r-- | test/CodeGen/Generic/GC/lower_gcroot.ll | 3 | ||||
-rw-r--r-- | test/Verifier/gcread-ptrptr.ll | 13 | ||||
-rw-r--r-- | test/Verifier/gcroot-alloca.ll | 14 | ||||
-rw-r--r-- | test/Verifier/gcroot-meta.ll | 16 | ||||
-rw-r--r-- | test/Verifier/gcroot-ptrptr.ll | 14 | ||||
-rw-r--r-- | test/Verifier/gcwrite-ptrptr.ll | 13 |
6 files changed, 72 insertions, 1 deletions
diff --git a/test/CodeGen/Generic/GC/lower_gcroot.ll b/test/CodeGen/Generic/GC/lower_gcroot.ll index 3a3abac..2dbbc83 100644 --- a/test/CodeGen/Generic/GC/lower_gcroot.ll +++ b/test/CodeGen/Generic/GC/lower_gcroot.ll @@ -3,7 +3,8 @@ %Env = type opaque* define void @.main(%Env) { - call void @llvm.gcroot( %Env* null, %Env null ) + %Root = alloca %Env + call void @llvm.gcroot( %Env* %Root, %Env null ) unreachable } diff --git a/test/Verifier/gcread-ptrptr.ll b/test/Verifier/gcread-ptrptr.ll new file mode 100644 index 0000000..bcfc6eb --- /dev/null +++ b/test/Verifier/gcread-ptrptr.ll @@ -0,0 +1,13 @@ +; RUN: not llvm-as < %s +; PR1633 + +%meta = type { i8* } +%obj = type { %meta* } + +declare %obj* @llvm.gcread(%obj*, %obj*) + +define %obj* @f() { +entry: + %x = call %obj* @llvm.gcread(%obj* null, %obj* null) + ret %obj* %x +} diff --git a/test/Verifier/gcroot-alloca.ll b/test/Verifier/gcroot-alloca.ll new file mode 100644 index 0000000..c44321a --- /dev/null +++ b/test/Verifier/gcroot-alloca.ll @@ -0,0 +1,14 @@ +; RUN: not llvm-as < %s +; PR1633 + +%meta = type { i8* } +%obj = type { %meta* } + +declare void @llvm.gcroot(%obj**, %meta*) + +define void @f() { +entry: + call void @llvm.gcroot(%obj** null, %meta* null) + + ret void +} diff --git a/test/Verifier/gcroot-meta.ll b/test/Verifier/gcroot-meta.ll new file mode 100644 index 0000000..51d1951 --- /dev/null +++ b/test/Verifier/gcroot-meta.ll @@ -0,0 +1,16 @@ +; RUN: not llvm-as < %s +; PR1633 + +%meta = type { i8* } +%obj = type { %meta* } + +declare void @llvm.gcroot(%obj**, %meta*) + +define void @f() { +entry: + %local.obj = alloca %obj* + %local.meta = alloca %meta + call void @llvm.gcroot(%obj** %local.obj, %meta* %local.meta) + + ret void +} diff --git a/test/Verifier/gcroot-ptrptr.ll b/test/Verifier/gcroot-ptrptr.ll new file mode 100644 index 0000000..0a7738d --- /dev/null +++ b/test/Verifier/gcroot-ptrptr.ll @@ -0,0 +1,14 @@ +; RUN: not llvm-as < %s +; PR1633 + +%meta = type { i8* } +%obj = type { %meta* } + +declare void @llvm.gcroot(%obj*, %meta*) + +define void @f() { +entry: + %local.obj = alloca %obj + call void @llvm.gcroot(%obj* %local.obj, %meta* null) + ret void +} diff --git a/test/Verifier/gcwrite-ptrptr.ll b/test/Verifier/gcwrite-ptrptr.ll new file mode 100644 index 0000000..b1e96c8 --- /dev/null +++ b/test/Verifier/gcwrite-ptrptr.ll @@ -0,0 +1,13 @@ +; RUN: not llvm-as < %s +; PR1633 + +%meta = type { i8* } +%obj = type { %meta* } + +declare void @llvm.gcwrite(%obj*, %obj*, %obj*) + +define void @f() { +entry: + call void @llvm.gcwrite(%obj* null, %obj* null, %obj* null) + ret void +} |