diff options
| author | Rafael Espindola <rafael.espindola@gmail.com> | 2013-10-31 20:51:58 +0000 |
|---|---|---|
| committer | Rafael Espindola <rafael.espindola@gmail.com> | 2013-10-31 20:51:58 +0000 |
| commit | 7e667c56cf7e27ff521ceb86518beab32bfb630d (patch) | |
| tree | 70a76ad0c4af2d93a15e630ebd9864665253a72f /tools/lto | |
| parent | f7ba4897302bf930f7ec4682a296ff4cd736a0e3 (diff) | |
| download | external_llvm-7e667c56cf7e27ff521ceb86518beab32bfb630d.zip external_llvm-7e667c56cf7e27ff521ceb86518beab32bfb630d.tar.gz external_llvm-7e667c56cf7e27ff521ceb86518beab32bfb630d.tar.bz2 | |
Use LTO_SYMBOL_SCOPE_DEFAULT_CAN_BE_HIDDEN instead of the "dso list".
There are two ways one could implement hiding of linkonce_odr symbols in LTO:
* LLVM tells the linker which symbols can be hidden if not used from native
files.
* The linker tells LLVM which symbols are not used from other object files,
but will be put in the dso symbol table if present.
GOLD's API is the second option. It was implemented almost 1:1 in llvm by
passing the list down to internalize.
LLVM already had partial support for the first option. It is also very similar
to how ld64 handles hiding these symbols when *not* doing LTO.
This patch then
* removes the APIs for the DSO list.
* marks LTO_SYMBOL_SCOPE_DEFAULT_CAN_BE_HIDDEN all linkonce_odr unnamed_addr
global values and other linkonce_odr whose address is not used.
* makes the gold plugin responsible for handling the API mismatch.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@193800 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'tools/lto')
| -rw-r--r-- | tools/lto/lto.cpp | 4 | ||||
| -rw-r--r-- | tools/lto/lto.exports | 1 |
2 files changed, 0 insertions, 5 deletions
diff --git a/tools/lto/lto.cpp b/tools/lto/lto.cpp index a3acd4c..7bfddcd 100644 --- a/tools/lto/lto.cpp +++ b/tools/lto/lto.cpp @@ -260,10 +260,6 @@ void lto_codegen_add_must_preserve_symbol(lto_code_gen_t cg, cg->addMustPreserveSymbol(symbol); } -void lto_codegen_add_dso_symbol(lto_code_gen_t cg, const char *symbol) { - cg->addDSOSymbol(symbol); -} - /// lto_codegen_write_merged_modules - Writes a new file at the specified path /// that contains the merged contents of all modules added so far. Returns true /// on error (check lto_get_error_message() for details). diff --git a/tools/lto/lto.exports b/tools/lto/lto.exports index c0e220b..46d0d74 100644 --- a/tools/lto/lto.exports +++ b/tools/lto/lto.exports @@ -15,7 +15,6 @@ lto_module_is_object_file_for_target lto_module_is_object_file_in_memory lto_module_is_object_file_in_memory_for_target lto_module_dispose -lto_codegen_add_dso_symbol lto_codegen_add_module lto_codegen_add_must_preserve_symbol lto_codegen_compile |