diff options
| -rw-r--r-- | include/llvm/GlobalValue.h | 6 | ||||
| -rw-r--r-- | lib/Transforms/IPO/GlobalOpt.cpp | 11 | ||||
| -rw-r--r-- | test/Transforms/GlobalOpt/hidden.ll | 14 |
3 files changed, 0 insertions, 31 deletions
diff --git a/include/llvm/GlobalValue.h b/include/llvm/GlobalValue.h index 3b83b5a..8b969f3 100644 --- a/include/llvm/GlobalValue.h +++ b/include/llvm/GlobalValue.h @@ -122,9 +122,6 @@ public: static bool isAvailableExternallyLinkage(LinkageTypes Linkage) { return Linkage == AvailableExternallyLinkage; } - static bool isLinkOnceODRLinkage(LinkageTypes Linkage) { - return Linkage == LinkOnceODRLinkage; - } static bool isLinkOnceLinkage(LinkageTypes Linkage) { return Linkage == LinkOnceAnyLinkage || Linkage == LinkOnceODRLinkage; } @@ -205,9 +202,6 @@ public: bool hasAvailableExternallyLinkage() const { return isAvailableExternallyLinkage(Linkage); } - bool hasLinkOnceODRLinkage() const { - return isLinkOnceODRLinkage(Linkage); - } bool hasLinkOnceLinkage() const { return isLinkOnceLinkage(Linkage); } diff --git a/lib/Transforms/IPO/GlobalOpt.cpp b/lib/Transforms/IPO/GlobalOpt.cpp index 2f1af18..35f98b2 100644 --- a/lib/Transforms/IPO/GlobalOpt.cpp +++ b/lib/Transforms/IPO/GlobalOpt.cpp @@ -1731,12 +1731,6 @@ bool GlobalOpt::ProcessGlobal(GlobalVariable *GV, return true; } - if (GV->hasLinkOnceODRLinkage() && GV->hasUnnamedAddr() && GV->isConstant() && - GV->getVisibility() != GlobalValue::HiddenVisibility) { - GV->setVisibility(GlobalValue::HiddenVisibility); - return true; - } - if (!GV->hasLocalLinkage()) return false; @@ -1749,7 +1743,6 @@ bool GlobalOpt::ProcessGlobal(GlobalVariable *GV, if (!GS.isCompared && !GV->hasUnnamedAddr()) { GV->setUnnamedAddr(true); NumUnnamed++; - return true; } if (GV->isConstant() || !GV->hasInitializer()) @@ -1924,10 +1917,6 @@ bool GlobalOpt::OptimizeFunctions(Module &M) { F->eraseFromParent(); Changed = true; ++NumFnDeleted; - } else if (F->hasLinkOnceODRLinkage() && F->hasUnnamedAddr() && - F->getVisibility() != GlobalValue::HiddenVisibility) { - F->setVisibility(GlobalValue::HiddenVisibility); - Changed = true; } else if (F->hasLocalLinkage()) { if (F->getCallingConv() == CallingConv::C && !F->isVarArg() && !F->hasAddressTaken()) { diff --git a/test/Transforms/GlobalOpt/hidden.ll b/test/Transforms/GlobalOpt/hidden.ll deleted file mode 100644 index 301e158..0000000 --- a/test/Transforms/GlobalOpt/hidden.ll +++ /dev/null @@ -1,14 +0,0 @@ -; RUN: opt %s -globalopt -S | FileCheck %s - -@foo = linkonce_odr unnamed_addr constant i32 42 -; CHECK: @foo = linkonce_odr hidden unnamed_addr constant i32 42 - -define linkonce_odr void @bar() unnamed_addr { -; CHECK: define linkonce_odr hidden void @bar() unnamed_addr { - ret void -} - -define i32* @zed() { - call void @bar() - ret i32* @foo -} |