aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--include/llvm/ADT/MapVector.h11
-rw-r--r--unittests/ADT/MapVectorTest.cpp16
2 files changed, 19 insertions, 8 deletions
diff --git a/include/llvm/ADT/MapVector.h b/include/llvm/ADT/MapVector.h
index 405fc43..f6fcb08 100644
--- a/include/llvm/ADT/MapVector.h
+++ b/include/llvm/ADT/MapVector.h
@@ -119,14 +119,11 @@ public:
(Vector.begin() + Pos->second);
}
- /// \brief Erase entry with the given key.
- void erase(const KeyT &key) {
- typename MapType::iterator Pos = Map.find(key);
- if (Pos == Map.end())
- return;
-
- Vector.erase(Vector.begin() + Pos->second);
+ /// \brief Remove the last element from the vector.
+ void pop_back() {
+ typename MapType::iterator Pos = Map.find(Vector.back().first);
Map.erase(Pos);
+ Vector.pop_back();
}
};
diff --git a/unittests/ADT/MapVectorTest.cpp b/unittests/ADT/MapVectorTest.cpp
index 9f61369..11178bc 100644
--- a/unittests/ADT/MapVectorTest.cpp
+++ b/unittests/ADT/MapVectorTest.cpp
@@ -13,7 +13,7 @@
using namespace llvm;
-TEST(MapVectorTest, insert) {
+TEST(MapVectorTest, insert_pop) {
MapVector<int, int> MV;
std::pair<MapVector<int, int>::iterator, bool> R;
@@ -38,4 +38,18 @@ TEST(MapVectorTest, insert) {
EXPECT_EQ(MV.size(), 2u);
EXPECT_EQ(MV[1], 2);
EXPECT_EQ(MV[4], 5);
+
+ MV.pop_back();
+ EXPECT_EQ(MV.size(), 1u);
+ EXPECT_EQ(MV[1], 2);
+
+ R = MV.insert(std::make_pair(4, 7));
+ ASSERT_NE(R.first, MV.end());
+ EXPECT_EQ(R.first->first, 4);
+ EXPECT_EQ(R.first->second, 7);
+ EXPECT_TRUE(R.second);
+
+ EXPECT_EQ(MV.size(), 2u);
+ EXPECT_EQ(MV[1], 2);
+ EXPECT_EQ(MV[4], 7);
}