summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBrian Paul <brianp@vmware.com>2012-12-10 12:35:23 -0700
committerBrian Paul <brianp@vmware.com>2012-12-11 12:48:07 -0700
commit2ee0b442528c7d0d0207504e8d315dfb5666afcd (patch)
treeb164982f86ae0397f0be48ec6d015a5aad04a0a4
parent3427466e6dbbb8db7c1ecda6b3859ca1cc5827a3 (diff)
downloadexternal_mesa3d-2ee0b442528c7d0d0207504e8d315dfb5666afcd.zip
external_mesa3d-2ee0b442528c7d0d0207504e8d315dfb5666afcd.tar.gz
external_mesa3d-2ee0b442528c7d0d0207504e8d315dfb5666afcd.tar.bz2
llvmpipe: don't use user constant buffers
This fixes some use-after-free issues. I haven't measured any real performance difference with a handful of Mesa demos. Reviewed-by: Jose Fonseca <jfonseca@vmware.com>
-rw-r--r--src/gallium/drivers/llvmpipe/lp_screen.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/src/gallium/drivers/llvmpipe/lp_screen.c b/src/gallium/drivers/llvmpipe/lp_screen.c
index 0f30447..ab5a55b 100644
--- a/src/gallium/drivers/llvmpipe/lp_screen.c
+++ b/src/gallium/drivers/llvmpipe/lp_screen.c
@@ -203,8 +203,9 @@ llvmpipe_get_param(struct pipe_screen *screen, enum pipe_cap param)
return 0;
case PIPE_CAP_USER_VERTEX_BUFFERS:
case PIPE_CAP_USER_INDEX_BUFFERS:
- case PIPE_CAP_USER_CONSTANT_BUFFERS:
return 1;
+ case PIPE_CAP_USER_CONSTANT_BUFFERS:
+ return 0;
case PIPE_CAP_VERTEX_BUFFER_OFFSET_4BYTE_ALIGNED_ONLY:
case PIPE_CAP_VERTEX_BUFFER_STRIDE_4BYTE_ALIGNED_ONLY:
case PIPE_CAP_VERTEX_ELEMENT_SRC_OFFSET_4BYTE_ALIGNED_ONLY: