diff options
| author | Carl Worth <cworth@cworth.org> | 2014-06-17 11:55:07 -0700 |
|---|---|---|
| committer | Carl Worth <cworth@cworth.org> | 2014-07-29 15:11:48 -0700 |
| commit | ea2e9300ece89dffdc4a228dc86bea28a7cd58e2 (patch) | |
| tree | f6057ff1a06c9037c52cd35d486f41eba2559ba0 | |
| parent | 9e45fb6f5127cecd02a1420aaea59a7012e74404 (diff) | |
| download | external_mesa3d-ea2e9300ece89dffdc4a228dc86bea28a7cd58e2.zip external_mesa3d-ea2e9300ece89dffdc4a228dc86bea28a7cd58e2.tar.gz external_mesa3d-ea2e9300ece89dffdc4a228dc86bea28a7cd58e2.tar.bz2 | |
glsl/glcpp: Emit proper error for #define with a non-identifier
Previously, if the preprocessor encountered a #define with a non-identifier,
such as:
#define 123 456
The lexer had no explicit rules to match non-identifiers in the <DEFINE> start
state. Because of this, flex's default rule was being invoked, (printing
characters to stdout), and all text was being discarded by the compiler until
the next identifier. As one can imagine, this led to all sorts of interesting
and surprising results.
Fix this by adding an explicit rule complementing the existing
identifier-based rules that should catch all non-identifiers after #define and
reliably give a well-formatted error message.
A new test is added to "make check" to ensure this bug stays fixed.
This commit also fixes the following Khronos GLES3 CTS test:
define_non_identifier_vertex
(The "fragment" variant was passing earlier only because the preprocessor was
behaving so randomly and causing the compilation to fail. It's lucky, in fact,
that the "vertex" version succesfully compiled so we could find and fix this
bug.)
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
| -rw-r--r-- | src/glsl/glcpp/glcpp-lex.l | 6 | ||||
| -rw-r--r-- | src/glsl/glcpp/tests/129-define-non-identifier.c | 1 | ||||
| -rw-r--r-- | src/glsl/glcpp/tests/129-define-non-identifier.c.expected | 2 |
3 files changed, 9 insertions, 0 deletions
diff --git a/src/glsl/glcpp/glcpp-lex.l b/src/glsl/glcpp/glcpp-lex.l index cfb9f2a..0d4bfc8 100644 --- a/src/glsl/glcpp/glcpp-lex.l +++ b/src/glsl/glcpp/glcpp-lex.l @@ -259,6 +259,12 @@ HEXADECIMAL_INTEGER 0[xX][0-9a-fA-F]+[uU]? return OBJ_IDENTIFIER; } +<DEFINE>[^_a-zA-Z]{NONSPACE}* { + BEGIN INITIAL; + glcpp_error(yylloc, yyextra, "#define followed by a non-identifier: %s", yytext); + return INTEGER_STRING; +} + {HASH}undef { yyextra->space_tokens = 0; return HASH_UNDEF; diff --git a/src/glsl/glcpp/tests/129-define-non-identifier.c b/src/glsl/glcpp/tests/129-define-non-identifier.c new file mode 100644 index 0000000..a229179 --- /dev/null +++ b/src/glsl/glcpp/tests/129-define-non-identifier.c @@ -0,0 +1 @@ +#define 123 456 diff --git a/src/glsl/glcpp/tests/129-define-non-identifier.c.expected b/src/glsl/glcpp/tests/129-define-non-identifier.c.expected new file mode 100644 index 0000000..b460357 --- /dev/null +++ b/src/glsl/glcpp/tests/129-define-non-identifier.c.expected @@ -0,0 +1,2 @@ +0:1(10): preprocessor error: #define followed by a non-identifier: 123 +0:1(10): preprocessor error: syntax error, unexpected INTEGER_STRING, expecting FUNC_IDENTIFIER or OBJ_IDENTIFIER |