summaryrefslogtreecommitdiffstats
path: root/src/egl/main/eglsync.c
diff options
context:
space:
mode:
authorDongwon Kim <dongwon.kim@intel.com>2016-02-02 15:06:28 -0800
committerEmil Velikov <emil.l.velikov@gmail.com>2016-02-19 18:23:19 +0000
commitd1e1563bb63f08cdfec1b40b105bec7f343bc0b8 (patch)
treeee8578a20cac60782ffd72788b6ebbd514ef0eb5 /src/egl/main/eglsync.c
parentb697400a97d3137ff87560ebd2c41207b98cd61a (diff)
downloadexternal_mesa3d-d1e1563bb63f08cdfec1b40b105bec7f343bc0b8.zip
external_mesa3d-d1e1563bb63f08cdfec1b40b105bec7f343bc0b8.tar.gz
external_mesa3d-d1e1563bb63f08cdfec1b40b105bec7f343bc0b8.tar.bz2
egl: move Null check to eglGetSyncAttribKHR to prevent Segfault
Null-check on "*value" is currently done in _eglGetSyncAttrib, which is after eglGetSyncAttribKHR dereferences it. Move the check a layer up (in the beginning of eglGetSyncAttribKHR) to avoid segfaults. Cc: "11.0 11.1" <mesa-stable@lists.freedesktop.org Signed-off-by: Dongwon Kim <dongwon.kim@intel.com> Reviewed-by: Marek Olšák <marek.olsak@amd.com> [Emil Velikov: tweak commit message, add stable tag] Reviewed-by: Emil Velikov <emil.velikov@collabora.com>
Diffstat (limited to 'src/egl/main/eglsync.c')
-rw-r--r--src/egl/main/eglsync.c3
1 files changed, 0 insertions, 3 deletions
diff --git a/src/egl/main/eglsync.c b/src/egl/main/eglsync.c
index 3019e6e..999cb48 100644
--- a/src/egl/main/eglsync.c
+++ b/src/egl/main/eglsync.c
@@ -144,9 +144,6 @@ EGLBoolean
_eglGetSyncAttrib(_EGLDriver *drv, _EGLDisplay *dpy, _EGLSync *sync,
EGLint attribute, EGLAttrib *value)
{
- if (!value)
- return _eglError(EGL_BAD_PARAMETER, "eglGetSyncAttribKHR");
-
switch (attribute) {
case EGL_SYNC_TYPE_KHR:
*value = sync->Type;