diff options
| author | Chad Versace <chad.versace@linux.intel.com> | 2013-08-01 08:10:31 -0700 |
|---|---|---|
| committer | Chad Versace <chad.versace@linux.intel.com> | 2013-08-08 15:17:51 -0700 |
| commit | 2c2e64edaba0f6aeb181ca5b51eb8dea8e9b39f9 (patch) | |
| tree | 01dbda144eb51ee72d134f32bdea215fd0cfcd4d /src/egl/wayland | |
| parent | fb3d62fe3d4fc40ba4ad9804d8b6f451316c9ae2 (diff) | |
| download | external_mesa3d-2c2e64edaba0f6aeb181ca5b51eb8dea8e9b39f9.zip external_mesa3d-2c2e64edaba0f6aeb181ca5b51eb8dea8e9b39f9.tar.gz external_mesa3d-2c2e64edaba0f6aeb181ca5b51eb8dea8e9b39f9.tar.bz2 | |
egl: Do not export private symbols
libEGL was incorrectly exporting *all* symbols, public and private.
This patch adds -fvisibility=hidden to libEGL's linker flags to ensure
that only symbols annotated with __attribute__((visibility("default")))
get exported.
Sanity-checked with libEGL's builtin DRI2 driver and the i965 DRI driver
by running Piglit on X/EGL and by running weston-gears on Weston as an
X client.
Sanity-checked with libEGL's Gallium driver (which is not built-in) and
the swrast Gallium driver by running es2gears_x11.
Kristian reviewed the symbol diff in `nm libEGL.so`.
CC: "9.2" <mesa-stable@lists.freedesktop.org>
CC: Ian Romanick <idr@freedesktop.org>
Acked-by: Kristian Høgsberg <krh@bitplanet.net>
Reviewed-by: Jakob Bornecrantz <jakob@vmware.com>
Signed-off-by: Chad Versace <chad.versace@linux.intel.com>
Diffstat (limited to 'src/egl/wayland')
| -rw-r--r-- | src/egl/wayland/wayland-drm/Makefile.am | 1 | ||||
| -rw-r--r-- | src/egl/wayland/wayland-egl/Makefile.am | 1 |
2 files changed, 2 insertions, 0 deletions
diff --git a/src/egl/wayland/wayland-drm/Makefile.am b/src/egl/wayland/wayland-drm/Makefile.am index 4b2aeb3..08ee497 100644 --- a/src/egl/wayland/wayland-drm/Makefile.am +++ b/src/egl/wayland/wayland-drm/Makefile.am @@ -1,6 +1,7 @@ AM_CFLAGS = -I$(top_srcdir)/src/egl/main \ -I$(top_srcdir)/include \ $(DEFINES) \ + $(VISIBILITY_CFLAGS) \ $(WAYLAND_CFLAGS) noinst_LTLIBRARIES = libwayland-drm.la diff --git a/src/egl/wayland/wayland-egl/Makefile.am b/src/egl/wayland/wayland-egl/Makefile.am index 7d20a1a..138c170 100644 --- a/src/egl/wayland/wayland-egl/Makefile.am +++ b/src/egl/wayland/wayland-egl/Makefile.am @@ -2,6 +2,7 @@ pkgconfigdir = $(libdir)/pkgconfig pkgconfig_DATA = wayland-egl.pc AM_CFLAGS = $(DEFINES) \ + $(VISIBILITY_CFLAGS) \ $(WAYLAND_CFLAGS) lib_LTLIBRARIES = libwayland-egl.la |