summaryrefslogtreecommitdiffstats
path: root/src/gallium/auxiliary/gallivm/lp_bld_sample.c
diff options
context:
space:
mode:
authorRoland Scheidegger <sroland@vmware.com>2013-02-23 01:16:54 +0100
committerRoland Scheidegger <sroland@vmware.com>2013-02-25 20:38:23 +0100
commitc0ba1080df4fa75ba23f254f2f998c97af70764b (patch)
tree97351c207ee53478c5dc02a604875423380629ef /src/gallium/auxiliary/gallivm/lp_bld_sample.c
parent20183177a5803317fe69f1f1a8dfae4d18b3702f (diff)
downloadexternal_mesa3d-c0ba1080df4fa75ba23f254f2f998c97af70764b.zip
external_mesa3d-c0ba1080df4fa75ba23f254f2f998c97af70764b.tar.gz
external_mesa3d-c0ba1080df4fa75ba23f254f2f998c97af70764b.tar.bz2
draw: make sure pipeline is revalidated when sampler views or samplers change.
Since with llvm execution parts of sampler view and sampler state is baked into the shader, we need to revalidate otherwise the wrong shader might get used. (Not completely sure but I think this would not be required for non-llvm case, along with everything else in these functions.) This caused bugs in piglit arb_texture_buffer_object-formats, because we never noticed that the view format changed. Reviewed-by: Jose Fonseca <jfonseca@vmware.com>
Diffstat (limited to 'src/gallium/auxiliary/gallivm/lp_bld_sample.c')
-rw-r--r--src/gallium/auxiliary/gallivm/lp_bld_sample.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/src/gallium/auxiliary/gallivm/lp_bld_sample.c b/src/gallium/auxiliary/gallivm/lp_bld_sample.c
index 5322397..ef0631c 100644
--- a/src/gallium/auxiliary/gallivm/lp_bld_sample.c
+++ b/src/gallium/auxiliary/gallivm/lp_bld_sample.c
@@ -117,7 +117,8 @@ lp_sampler_static_texture_state(struct lp_static_texture_state *state,
state->level_zero_only = !view->u.tex.last_level;
/*
- * FIXME: Handle the remainder of pipe_sampler_view.
+ * the layer / element / level parameters are all either dynamic
+ * state or handled transparently wrt execution.
*/
}