diff options
author | Martina Kollarova <martina.kollarova@intel.com> | 2016-09-08 15:12:42 +0300 |
---|---|---|
committer | Emil Velikov <emil.l.velikov@gmail.com> | 2016-09-14 14:36:43 +0100 |
commit | 2527e18eebe2faf395d1682db7df76043aca6ea3 (patch) | |
tree | 13c53ef4dfe8723df599d60fbac47a3dee6602c4 /src/gallium/winsys | |
parent | ab29788250a705eb0dd517cb3d38f37f944eb8ad (diff) | |
download | external_mesa3d-2527e18eebe2faf395d1682db7df76043aca6ea3.zip external_mesa3d-2527e18eebe2faf395d1682db7df76043aca6ea3.tar.gz external_mesa3d-2527e18eebe2faf395d1682db7df76043aca6ea3.tar.bz2 |
gallium: fix return value check
A possible error (-1) was being lost because it was first converted to an
unsigned int and only then checked.
Reviewed-by: Nicolai Hähnle <nicolai.haehnle@amd.com>
Signed-off-by: Martina Kollarova <martina.kollarova@intel.com>
Reviewed-by: Eric Engestrom <eric.engestrom@imgtec.com>
Diffstat (limited to 'src/gallium/winsys')
-rw-r--r-- | src/gallium/winsys/sw/kms-dri/kms_dri_sw_winsys.c | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/src/gallium/winsys/sw/kms-dri/kms_dri_sw_winsys.c b/src/gallium/winsys/sw/kms-dri/kms_dri_sw_winsys.c index 07eca99..22e1c93 100644 --- a/src/gallium/winsys/sw/kms-dri/kms_dri_sw_winsys.c +++ b/src/gallium/winsys/sw/kms-dri/kms_dri_sw_winsys.c @@ -252,18 +252,18 @@ kms_sw_displaytarget_add_from_prime(struct kms_sw_winsys *kms_sw, int fd, if (!kms_sw_dt) return NULL; + off_t lseek_ret = lseek(fd, 0, SEEK_END); + if (lseek_ret == -1) { + FREE(kms_sw_dt); + return NULL; + } + kms_sw_dt->size = lseek_ret; kms_sw_dt->ref_count = 1; kms_sw_dt->handle = handle; - kms_sw_dt->size = lseek(fd, 0, SEEK_END); kms_sw_dt->width = width; kms_sw_dt->height = height; kms_sw_dt->stride = stride; - if (kms_sw_dt->size == (off_t)-1) { - FREE(kms_sw_dt); - return NULL; - } - lseek(fd, 0, SEEK_SET); list_add(&kms_sw_dt->link, &kms_sw->bo_list); |