summaryrefslogtreecommitdiffstats
path: root/src/glx/indirect_glx.c
diff options
context:
space:
mode:
authorTomasz Lis <tomasz.lis@intel.com>2013-07-18 14:19:38 -0700
committerIan Romanick <ian.d.romanick@intel.com>2013-07-18 16:03:42 -0700
commit2eed9ff2fb5b218b7b274d2989b0dbbe5fcfedef (patch)
treec3b7db63922ed8d7d51783b27f240cad3045c46f /src/glx/indirect_glx.c
parent27c8aa5cfbcf6f2ad21564dfcdabbe747c277cab (diff)
downloadexternal_mesa3d-2eed9ff2fb5b218b7b274d2989b0dbbe5fcfedef.zip
external_mesa3d-2eed9ff2fb5b218b7b274d2989b0dbbe5fcfedef.tar.gz
external_mesa3d-2eed9ff2fb5b218b7b274d2989b0dbbe5fcfedef.tar.bz2
glx: Validate the GLX_RENDER_TYPE value
Correctly handle the value of renderType in GLX context. In case of the value being incorrect, context creation fails. v2 (idr): indirect_create_context is just a memory allocator, so don't validate the GLX_RENDER_TYPE there. Fixes regressions in several GLX_ARB_create_context piglit tests. Signed-off-by: Tomasz Lis <tomasz.lis@intel.com> Signed-off-by: Ian Romanick <ian.d.romanick@intel.com> Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Diffstat (limited to 'src/glx/indirect_glx.c')
-rw-r--r--src/glx/indirect_glx.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/src/glx/indirect_glx.c b/src/glx/indirect_glx.c
index 11e9297..f8944a7 100644
--- a/src/glx/indirect_glx.c
+++ b/src/glx/indirect_glx.c
@@ -335,6 +335,10 @@ static const struct glx_context_vtable indirect_context_vtable = {
* \todo Eliminate \c __glXInitVertexArrayState. Replace it with a new
* function called \c __glXAllocateClientState that allocates the memory and
* does all the initialization (including the pixel pack / unpack).
+ *
+ * \note
+ * This function is \b not the place to validate the context creation
+ * parameters. It is just the allocator for the \c glx_context.
*/
_X_HIDDEN struct glx_context *
indirect_create_context(struct glx_screen *psc,