diff options
| author | Ian Romanick <ian.d.romanick@intel.com> | 2011-11-28 18:31:21 -0800 |
|---|---|---|
| committer | Ian Romanick <ian.d.romanick@intel.com> | 2011-12-19 14:55:31 -0800 |
| commit | e4be406f09fcb3756cd0e8dd0539f62bafb1bcca (patch) | |
| tree | 0014520581e827e96b2bcc9741e0e1ae3d276d1e /src/glx | |
| parent | a832aa5ba097253f53983e3f1186b71626d164ae (diff) | |
| download | external_mesa3d-e4be406f09fcb3756cd0e8dd0539f62bafb1bcca.zip external_mesa3d-e4be406f09fcb3756cd0e8dd0539f62bafb1bcca.tar.gz external_mesa3d-e4be406f09fcb3756cd0e8dd0539f62bafb1bcca.tar.bz2 | |
glx: Explicitly reject servers that only support GLX 1.0
__glXInitialize calls AllocAndFetchScreenConfigs.
AllocAndFetchScreenConfigs unconditionally sends a glXQuerySeverString
request to the server. This request is only supported with GLX 1.1 or
later, so we were already implicitly incompatible with GLX 1.0
servers. How many more similar bugs lurk in the code that nobody has
noticed in years?
Signed-off-by: Ian Romanick <ian.d.romanick@intel.com>
Reviewed-by: Adam Jackson <ajax@redhat.com>
Reviewed-by: Eric Anholt <eric@anholt.net>
Diffstat (limited to 'src/glx')
| -rw-r--r-- | src/glx/glxext.c | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/src/glx/glxext.c b/src/glx/glxext.c index 8254544..baa2489 100644 --- a/src/glx/glxext.c +++ b/src/glx/glxext.c @@ -836,9 +836,12 @@ __glXInitialize(Display * dpy) dpyPriv->serverGLXvendor = 0x0; dpyPriv->serverGLXversion = 0x0; - /* See if the versions are compatible */ + /* See if the versions are compatible. This GLX implementation does not + * work with servers that only support GLX 1.0. + */ if (!QueryVersion(dpy, dpyPriv->majorOpcode, - &dpyPriv->majorVersion, &dpyPriv->minorVersion)) { + &dpyPriv->majorVersion, &dpyPriv->minorVersion) + || (dpyPriv->majorVersion == 1 && dpyPriv->minorVersion < 1)) { Xfree(dpyPriv); _XUnlockMutex(_Xglobal_lock); return NULL; @@ -884,8 +887,7 @@ __glXInitialize(Display * dpy) return NULL; } - if (dpyPriv->majorVersion == 1 && dpyPriv->minorVersion >= 1) - __glXClientInfo(dpy, dpyPriv->majorOpcode); + __glXClientInfo(dpy, dpyPriv->majorOpcode); /* Grab the lock again and add the dispay private, unless somebody * beat us to initializing on this display in the meantime. */ |