diff options
| author | Francisco Jerez <currojerez@riseup.net> | 2016-02-06 18:43:45 -0800 |
|---|---|---|
| committer | Francisco Jerez <currojerez@riseup.net> | 2016-02-08 15:43:05 -0800 |
| commit | 1817e3c07a63c6404d6df323fbd443ccd9304b02 (patch) | |
| tree | eb929e6c6c803de56f79a4d190c58a0ee8627436 /src/mesa/drivers/dri/i965/brw_fs_surface_builder.cpp | |
| parent | c300559fbfa6127320b78c130061fdb6a454658d (diff) | |
| download | external_mesa3d-1817e3c07a63c6404d6df323fbd443ccd9304b02.zip external_mesa3d-1817e3c07a63c6404d6df323fbd443ccd9304b02.tar.gz external_mesa3d-1817e3c07a63c6404d6df323fbd443ccd9304b02.tar.bz2 | |
i965/fs: Don't emit unnecessary SEL instruction from emit_image_atomic().
The SEL instruction with predication mode NONE emitted when the atomic
operation doesn't need to be predicated is a no-op and might rely on
undocumented hardware behaviour. Noticed by chance while looking at
the assembly output.
Reviewed-by: Matt Turner <mattst88@gmail.com>
Diffstat (limited to 'src/mesa/drivers/dri/i965/brw_fs_surface_builder.cpp')
| -rw-r--r-- | src/mesa/drivers/dri/i965/brw_fs_surface_builder.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/mesa/drivers/dri/i965/brw_fs_surface_builder.cpp b/src/mesa/drivers/dri/i965/brw_fs_surface_builder.cpp index 45694ec..081dbad 100644 --- a/src/mesa/drivers/dri/i965/brw_fs_surface_builder.cpp +++ b/src/mesa/drivers/dri/i965/brw_fs_surface_builder.cpp @@ -1122,7 +1122,7 @@ namespace brw { dims, rsize, op, pred); /* An unbound surface access should give zero as result. */ - if (rsize) + if (rsize && pred) set_predicate(pred, bld.SEL(tmp, tmp, brw_imm_d(0))); return tmp; |