diff options
| author | Chris Forbes <chrisf@ijw.co.nz> | 2013-12-01 11:07:46 +1300 |
|---|---|---|
| committer | Chris Forbes <chrisf@ijw.co.nz> | 2013-12-07 16:08:47 +1300 |
| commit | dfa952da97817093b7f7f95095c8598044126e09 (patch) | |
| tree | 54b140c6d351225495c79dd104e41a9f676d80b4 /src/mesa/drivers/dri | |
| parent | 8064b0f2c488f5c74a8910c2a5675672e8b1e066 (diff) | |
| download | external_mesa3d-dfa952da97817093b7f7f95095c8598044126e09.zip external_mesa3d-dfa952da97817093b7f7f95095c8598044126e09.tar.gz external_mesa3d-dfa952da97817093b7f7f95095c8598044126e09.tar.bz2 | |
i965/wm: Set copy of sample mask in 3DSTATE_PS correctly for Haswell
The bspec says:
"SW must program the sample mask value in this field so that it matches
with 3DSTATE_SAMPLE_MASK"
I haven't observed this to actually fix anything, but stumbled across it
while adding the rest of the support for CMS layout for multisample
textures.
Signed-off-by: Chris Forbes <chrisf@ijw.co.nz>
Reviewed-by: Paul Berry <stereotype441@gmail.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Diffstat (limited to 'src/mesa/drivers/dri')
| -rw-r--r-- | src/mesa/drivers/dri/i965/gen7_wm_state.c | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/src/mesa/drivers/dri/i965/gen7_wm_state.c b/src/mesa/drivers/dri/i965/gen7_wm_state.c index 65c9bbf..abbc73c 100644 --- a/src/mesa/drivers/dri/i965/gen7_wm_state.c +++ b/src/mesa/drivers/dri/i965/gen7_wm_state.c @@ -173,8 +173,11 @@ upload_ps_state(struct brw_context *brw) if (ctx->Shader.CurrentFragmentProgram == NULL) dw2 |= GEN7_PS_FLOATING_POINT_MODE_ALT; + /* Haswell requires the sample mask to be set in this packet as well as + * in 3DSTATE_SAMPLE_MASK; the values should match. */ + /* _NEW_BUFFERS, _NEW_MULTISAMPLE */ if (brw->is_haswell) - dw4 |= SET_FIELD(1, HSW_PS_SAMPLE_MASK); /* 1 sample for now */ + dw4 |= SET_FIELD(gen6_determine_sample_mask(brw), HSW_PS_SAMPLE_MASK); dw4 |= (brw->max_wm_threads - 1) << max_threads_shift; @@ -274,7 +277,9 @@ upload_ps_state(struct brw_context *brw) const struct brw_tracked_state gen7_ps_state = { .dirty = { .mesa = (_NEW_PROGRAM_CONSTANTS | - _NEW_COLOR), + _NEW_COLOR | + _NEW_BUFFERS | + _NEW_MULTISAMPLE), .brw = (BRW_NEW_FRAGMENT_PROGRAM | BRW_NEW_PS_BINDING_TABLE | BRW_NEW_BATCH | |