summaryrefslogtreecommitdiffstats
path: root/src/mesa/main/eval.c
diff options
context:
space:
mode:
authorBrian Paul <brianp@vmware.com>2012-09-03 08:12:04 -0600
committerBrian Paul <brianp@vmware.com>2012-09-03 18:07:41 -0600
commit2276bb991ac091b2b42274c2a094ba6f1de08468 (patch)
tree8b486983c8f04b60ebe5e995cf0ce5856b0cf807 /src/mesa/main/eval.c
parent56ccdf7e30f5bc1bc6b71d49bad2a9049ae170c4 (diff)
downloadexternal_mesa3d-2276bb991ac091b2b42274c2a094ba6f1de08468.zip
external_mesa3d-2276bb991ac091b2b42274c2a094ba6f1de08468.tar.gz
external_mesa3d-2276bb991ac091b2b42274c2a094ba6f1de08468.tar.bz2
mesa: remove null pointer checks before free() calls
Since free(NULL) is fine. Reviewed-by: Kenneth Graunke <kenneth@whitecape.org> Reviewed-by: Jose Fonseca <jfonseca@vmware.com>
Diffstat (limited to 'src/mesa/main/eval.c')
-rw-r--r--src/mesa/main/eval.c68
1 files changed, 24 insertions, 44 deletions
diff --git a/src/mesa/main/eval.c b/src/mesa/main/eval.c
index 0ae349f..7709217 100644
--- a/src/mesa/main/eval.c
+++ b/src/mesa/main/eval.c
@@ -415,8 +415,7 @@ map1(GLenum target, GLfloat u1, GLfloat u2, GLint ustride,
map->u1 = u1;
map->u2 = u2;
map->du = 1.0F / (u2 - u1);
- if (map->Points)
- free( map->Points );
+ free(map->Points);
map->Points = pnts;
}
@@ -515,8 +514,7 @@ map2( GLenum target, GLfloat u1, GLfloat u2, GLint ustride, GLint uorder,
map->v1 = v1;
map->v2 = v2;
map->dv = 1.0F / (v2 - v1);
- if (map->Points)
- free( map->Points );
+ free(map->Points);
map->Points = pnts;
}
@@ -1047,45 +1045,27 @@ void _mesa_free_eval_data( struct gl_context *ctx )
int i;
/* Free evaluator data */
- if (ctx->EvalMap.Map1Vertex3.Points)
- free( ctx->EvalMap.Map1Vertex3.Points );
- if (ctx->EvalMap.Map1Vertex4.Points)
- free( ctx->EvalMap.Map1Vertex4.Points );
- if (ctx->EvalMap.Map1Index.Points)
- free( ctx->EvalMap.Map1Index.Points );
- if (ctx->EvalMap.Map1Color4.Points)
- free( ctx->EvalMap.Map1Color4.Points );
- if (ctx->EvalMap.Map1Normal.Points)
- free( ctx->EvalMap.Map1Normal.Points );
- if (ctx->EvalMap.Map1Texture1.Points)
- free( ctx->EvalMap.Map1Texture1.Points );
- if (ctx->EvalMap.Map1Texture2.Points)
- free( ctx->EvalMap.Map1Texture2.Points );
- if (ctx->EvalMap.Map1Texture3.Points)
- free( ctx->EvalMap.Map1Texture3.Points );
- if (ctx->EvalMap.Map1Texture4.Points)
- free( ctx->EvalMap.Map1Texture4.Points );
- for (i = 0; i < 16; i++)
- free((ctx->EvalMap.Map1Attrib[i].Points));
-
- if (ctx->EvalMap.Map2Vertex3.Points)
- free( ctx->EvalMap.Map2Vertex3.Points );
- if (ctx->EvalMap.Map2Vertex4.Points)
- free( ctx->EvalMap.Map2Vertex4.Points );
- if (ctx->EvalMap.Map2Index.Points)
- free( ctx->EvalMap.Map2Index.Points );
- if (ctx->EvalMap.Map2Color4.Points)
- free( ctx->EvalMap.Map2Color4.Points );
- if (ctx->EvalMap.Map2Normal.Points)
- free( ctx->EvalMap.Map2Normal.Points );
- if (ctx->EvalMap.Map2Texture1.Points)
- free( ctx->EvalMap.Map2Texture1.Points );
- if (ctx->EvalMap.Map2Texture2.Points)
- free( ctx->EvalMap.Map2Texture2.Points );
- if (ctx->EvalMap.Map2Texture3.Points)
- free( ctx->EvalMap.Map2Texture3.Points );
- if (ctx->EvalMap.Map2Texture4.Points)
- free( ctx->EvalMap.Map2Texture4.Points );
- for (i = 0; i < 16; i++)
+ free(ctx->EvalMap.Map1Vertex3.Points);
+ free(ctx->EvalMap.Map1Vertex4.Points);
+ free(ctx->EvalMap.Map1Index.Points);
+ free(ctx->EvalMap.Map1Color4.Points);
+ free(ctx->EvalMap.Map1Normal.Points);
+ free(ctx->EvalMap.Map1Texture1.Points);
+ free(ctx->EvalMap.Map1Texture2.Points);
+ free(ctx->EvalMap.Map1Texture3.Points);
+ free(ctx->EvalMap.Map1Texture4.Points);
+ for (i = 0; i < Elements(ctx->EvalMap.Map1Attrib); i++)
+ free(ctx->EvalMap.Map1Attrib[i].Points);
+
+ free(ctx->EvalMap.Map2Vertex3.Points);
+ free(ctx->EvalMap.Map2Vertex4.Points);
+ free(ctx->EvalMap.Map2Index.Points);
+ free(ctx->EvalMap.Map2Color4.Points);
+ free(ctx->EvalMap.Map2Normal.Points);
+ free(ctx->EvalMap.Map2Texture1.Points);
+ free(ctx->EvalMap.Map2Texture2.Points);
+ free(ctx->EvalMap.Map2Texture3.Points);
+ free(ctx->EvalMap.Map2Texture4.Points);
+ for (i = 0; i < Elements(ctx->EvalMap.Map2Attrib); i++)
free((ctx->EvalMap.Map2Attrib[i].Points));
}