diff options
| author | Jamey Sharp <jamey@minilop.net> | 2016-04-25 22:06:40 -0700 |
|---|---|---|
| committer | Timothy Arceri <timothy.arceri@collabora.com> | 2016-05-01 18:46:24 +1000 |
| commit | 595d56cc866638f371626cc1d0137a6a54a7d0f8 (patch) | |
| tree | 043dd5586c995ae132117d98880c54f156ee4b7b /src/mesa/main/shaderapi.c | |
| parent | 9fa2e57a738d20a2b77ae0a5e9ad717b529321b4 (diff) | |
| download | external_mesa3d-595d56cc866638f371626cc1d0137a6a54a7d0f8.zip external_mesa3d-595d56cc866638f371626cc1d0137a6a54a7d0f8.tar.gz external_mesa3d-595d56cc866638f371626cc1d0137a6a54a7d0f8.tar.bz2 | |
glShaderSource must not change compile status.
OpenGL 4.5 Core Profile section 7.1, in the documentation for
CompileShader, says: "Changing the source code of a shader object with
ShaderSource does not change its compile status or the compiled shader
code."
According to Karol Herbst, the game "Divinity: Original Sin - Enhanced
Edition" depends on this odd quirk of the spec.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=93551
Signed-off-by: Jamey Sharp <jamey@minilop.net>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Timothy Arceri <timothy.arceri@collabora.com>
Diffstat (limited to 'src/mesa/main/shaderapi.c')
| -rw-r--r-- | src/mesa/main/shaderapi.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c index b972f8e..8c1fba8 100644 --- a/src/mesa/main/shaderapi.c +++ b/src/mesa/main/shaderapi.c @@ -949,7 +949,6 @@ shader_source(struct gl_shader *sh, const GLchar *source) /* free old shader source string and install new one */ free((void *)sh->Source); sh->Source = source; - sh->CompileStatus = GL_FALSE; #ifdef DEBUG sh->SourceChecksum = _mesa_str_checksum(sh->Source); #endif |