diff options
| author | Brian Paul <brianp@vmware.com> | 2016-04-07 17:38:41 -0600 |
|---|---|---|
| committer | Brian Paul <brianp@vmware.com> | 2016-04-08 09:49:05 -0600 |
| commit | 4420f189b6d6dd68b517cd73dfdf3775d7d0f580 (patch) | |
| tree | f205f4e30d59ec5ff23fc6ba8714a2543aaef681 /src/mesa/state_tracker/st_cb_fbo.c | |
| parent | b9855dcdf7c94605305d6372d1f9883f76d10b6a (diff) | |
| download | external_mesa3d-4420f189b6d6dd68b517cd73dfdf3775d7d0f580.zip external_mesa3d-4420f189b6d6dd68b517cd73dfdf3775d7d0f580.tar.gz external_mesa3d-4420f189b6d6dd68b517cd73dfdf3775d7d0f580.tar.bz2 | |
st/mesa: fix glReadBuffer() assertion failure
If the first call in a GL app is glReadPixels(GL_FRONT) we'd fail the
assert(st->ctx->FragmentProgram._Current) at st_atom_shader.c:114 in
update_fp().
This is because we were calling st_validate_state() without first
updating Mesa state with _mesa_update_state().
The regression came from commit 83b589301f4a150f4 "st/mesa: fix
frontbuffer glReadPixels regressions".
The new piglit gl-1.0-simple-readbuffer test exercises this.
Cc: "11.1 11.2" <mesa-stable@lists.freedesktop.org>
Reviewed-by: Roland Scheidegger <sroland@vmware.com>
Reviewed-by: Jose Fonseca <jfonseca@vmware.com>
Diffstat (limited to 'src/mesa/state_tracker/st_cb_fbo.c')
| -rw-r--r-- | src/mesa/state_tracker/st_cb_fbo.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/src/mesa/state_tracker/st_cb_fbo.c b/src/mesa/state_tracker/st_cb_fbo.c index ff570e0..456ad83 100644 --- a/src/mesa/state_tracker/st_cb_fbo.c +++ b/src/mesa/state_tracker/st_cb_fbo.c @@ -40,6 +40,7 @@ #include "main/glformats.h" #include "main/macros.h" #include "main/renderbuffer.h" +#include "main/state.h" #include "pipe/p_context.h" #include "pipe/p_defines.h" @@ -729,6 +730,7 @@ st_ReadBuffer(struct gl_context *ctx, GLenum buffer) fb->Attachment[fb->_ColorReadBufferIndex].Type == GL_NONE) { /* add the buffer */ st_manager_add_color_renderbuffer(st, fb, fb->_ColorReadBufferIndex); + _mesa_update_state(ctx); st_validate_state(st, ST_PIPELINE_RENDER); } } |