diff options
| author | Neil Roberts <neil@linux.intel.com> | 2015-05-08 16:13:52 +0100 |
|---|---|---|
| committer | Neil Roberts <neil@linux.intel.com> | 2015-05-08 16:16:56 +0100 |
| commit | f98c3f3e44abb0c8cb158c589418def111d72052 (patch) | |
| tree | ab326d37920b3644c039126ddc976336789d269e /src/mesa | |
| parent | b004510072a2995463f57f3b79d43429729134d2 (diff) | |
| download | external_mesa3d-f98c3f3e44abb0c8cb158c589418def111d72052.zip external_mesa3d-f98c3f3e44abb0c8cb158c589418def111d72052.tar.gz external_mesa3d-f98c3f3e44abb0c8cb158c589418def111d72052.tar.bz2 | |
i965/fs: Improve a comment about stripping trailing zeroes
Originally I wrote that removing the first parameter doesn't work but
I didn't know why. I now found a mention of this in the PRM so it's
probably worthing adding it to the comment.
Diffstat (limited to 'src/mesa')
| -rw-r--r-- | src/mesa/drivers/dri/i965/brw_fs.cpp | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp index 8dd680e..b2701b8 100644 --- a/src/mesa/drivers/dri/i965/brw_fs.cpp +++ b/src/mesa/drivers/dri/i965/brw_fs.cpp @@ -2600,9 +2600,12 @@ fs_visitor::opt_zero_samples() load_payload->opcode != SHADER_OPCODE_LOAD_PAYLOAD) continue; - /* We don't want to remove the message header. Removing all of the - * parameters is avoided because it seems to cause a GPU hang but I - * can't find any documentation indicating that this is expected. + /* We don't want to remove the message header or the first parameter. + * Removing the first parameter is not allowed, see the Haswell PRM + * volume 7, page 149: + * + * "Parameter 0 is required except for the sampleinfo message, which + * has no parameter 0" */ while (inst->mlen > inst->header_size + dispatch_width / 8 && load_payload->src[(inst->mlen - inst->header_size) / |